Bug 49175 - Building for Android generates several compiler warnings
Summary: Building for Android generates several compiler warnings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Android Android
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-08 07:18 PST by Steve Block
Modified: 2010-11-08 14:52 PST (History)
2 users (show)

See Also:

Attachments
Patch (3.86 KB, patch)
2010-11-08 07:46 PST, Steve Block 		levin: review+
levin: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2010-11-08 07:18:19 PST 
These are due to signed/unsigned comparisons, assignment in if statements, braces in logical statements, and redefinition of macros.
Comment 1 Steve Block 2010-11-08 07:46:17 PST 
Created attachment 73239 [details]
Patch
Comment 2 David Levin 2010-11-08 11:21:59 PST 
Comment on attachment 73239 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=73239&action=review

Please fix typos in changelog.

> WebCore/ChangeLog:9
> +        - PREFIX_FOR_WEBCORE was previously required for STL's algirithm, but is no

typo: algirithm

> WebCore/ChangeLog:15
> +        No new tests, fixes compile arnings only.

typo: arnings
Comment 3 Steve Block 2010-11-08 14:52:54 PST 
Committed r71578: <http://trac.webkit.org/changeset/71578>