Bug 49155 - Remove the remaining editing-style functions from ApplyStyleCommand
Summary: Remove the remaining editing-style functions from ApplyStyleCommand
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Enhancement
Assignee: Ryosuke Niwa
Depends on: 46335
  Show dependency treegraph
Reported: 2010-11-07 20:22 PST by Ryosuke Niwa
Modified: 2010-11-08 12:15 PST (History)
4 users (show)

See Also:

cleanup (35.29 KB, patch)
2010-11-07 22:04 PST, Ryosuke Niwa
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2010-11-07 20:22:44 PST
This is a follow up to the bug 46335, which introduced EditingStyle.  In this follow up, we remove removeNonEditingProperties, editingStyleAtPosition, prepareEditingStyleToApplyAt, and removeStylesAddedByNode from ApplyStyleCommand.cpp/h.
Comment 1 Ryosuke Niwa 2010-11-07 22:04:11 PST
Created attachment 73211 [details]
Comment 2 Darin Adler 2010-11-08 10:43:40 PST
Comment on attachment 73211 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=73211&action=review

Seems good. Refactoring looks like it was done correctly.

> WebCore/editing/EditingStyle.h:72
> +    void removeStyleAddedByNode(Node* node);
> +    void removeStyleConflictingWithStyleOfNode(Node* node);

No need for argument names here in these function declarations.
Comment 3 Ryosuke Niwa 2010-11-08 12:15:51 PST
Committed r71556: <http://trac.webkit.org/changeset/71556>