Bug 49152 - Assert that a non-null PassRefPtr<Document> has a non-null frame in Frame::setDocument()
: Assert that a non-null PassRefPtr<Document> has a non-null frame in Frame::se...
Status: RESOLVED FIXED
: WebKit
WebCore Misc.
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2010-11-07 18:38 PST by
Modified: 2010-11-07 20:32 PST (History)


Attachments
Patch (1.32 KB, patch)
2010-11-07 18:48 PST, Daniel Bates
no flags Review Patch | Details | Formatted Diff | Diff
Patch (1.33 KB, patch)
2010-11-07 18:49 PST, Daniel Bates
abarth: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2010-11-07 18:38:24 PST
We should assert that a non-null Document object has a non-null frame (i.e. that Document::frame() is not null) in Frame::setDocument().
------- Comment #1 From 2010-11-07 18:48:18 PST -------
Created an attachment (id=73201) [details]
Patch

This change does not cause any DRT regressions on my Mac.

As far as I can tell from looking at the callers of Frame::setDocument() and the Document creation process, it doesn't make sense for Frame::setDocument() to be passed a non-null PassRefPtr<Document> whose Document has a null frame (i.e. Document::frame() == 0).
------- Comment #2 From 2010-11-07 18:49:56 PST -------
Created an attachment (id=73202) [details]
Patch

Updated title of bug in change log.
------- Comment #3 From 2010-11-07 19:08:39 PST -------
(From update of attachment 73202 [details])
Thanks.
------- Comment #4 From 2010-11-07 20:18:16 PST -------
(From update of attachment 73202 [details])
Will land by hand.
------- Comment #5 From 2010-11-07 20:32:39 PST -------
Committed r71493: <http://trac.webkit.org/changeset/71493>