Bug 49152 - Assert that a non-null PassRefPtr<Document> has a non-null frame in Frame::setDocument()
: Assert that a non-null PassRefPtr<Document> has a non-null frame in Frame::se...
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: WebCore Misc.
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To: Daniel Bates
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-11-07 18:38 PST by Daniel Bates
Modified: 2010-11-07 20:32 PST (History)
3 users (show)

See Also:


Attachments
Patch (1.32 KB, patch)
2010-11-07 18:48 PST, Daniel Bates
no flags Details | Formatted Diff | Diff
Patch (1.33 KB, patch)
2010-11-07 18:49 PST, Daniel Bates
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2010-11-07 18:38:24 PST
We should assert that a non-null Document object has a non-null frame (i.e. that Document::frame() is not null) in Frame::setDocument().
Comment 1 Daniel Bates 2010-11-07 18:48:18 PST
Created attachment 73201 [details]
Patch

This change does not cause any DRT regressions on my Mac.

As far as I can tell from looking at the callers of Frame::setDocument() and the Document creation process, it doesn't make sense for Frame::setDocument() to be passed a non-null PassRefPtr<Document> whose Document has a null frame (i.e. Document::frame() == 0).
Comment 2 Daniel Bates 2010-11-07 18:49:56 PST
Created attachment 73202 [details]
Patch

Updated title of bug in change log.
Comment 3 Adam Barth 2010-11-07 19:08:39 PST
Comment on attachment 73202 [details]
Patch

Thanks.
Comment 4 Daniel Bates 2010-11-07 20:18:16 PST
Comment on attachment 73202 [details]
Patch

Will land by hand.
Comment 5 Daniel Bates 2010-11-07 20:32:39 PST
Committed r71493: <http://trac.webkit.org/changeset/71493>