Bug 49137 - [chromium] WebViewClient needs an API to report progress load
Summary: [chromium] WebViewClient needs an API to report progress load
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-06 23:14 PDT by Jay Civelli
Modified: 2010-11-08 23:48 PST (History)
2 users (show)

See Also:


Attachments
Patch (6.07 KB, patch)
2010-11-06 23:17 PDT, Jay Civelli
no flags Details | Formatted Diff | Diff
Patch (2.40 KB, patch)
2010-11-06 23:34 PDT, Jay Civelli
no flags Details | Formatted Diff | Diff
Patch (2.50 KB, patch)
2010-11-08 14:07 PST, Jay Civelli
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jay Civelli 2010-11-06 23:14:17 PDT
WebViewClient should have a method that reports the load progress for frames.
Comment 1 Jay Civelli 2010-11-06 23:17:19 PDT
Created attachment 73188 [details]
Patch
Comment 2 Jay Civelli 2010-11-06 23:34:00 PDT
Created attachment 73189 [details]
Patch
Comment 3 Darin Fisher (:fishd, Google) 2010-11-08 10:34:19 PST
Comment on attachment 73189 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=73189&action=review

> WebKit/chromium/public/WebViewClient.h:122
> +    virtual void didMakeProgressLoading(WebFrame*, double loadProgress) { }

nit: perhaps didChangeLoadProgress would be a better name?  it matches the parameter name.
Comment 4 Jay Civelli 2010-11-08 14:07:20 PST
Created attachment 73277 [details]
Patch
Comment 5 WebKit Commit Bot 2010-11-08 23:48:33 PST
Comment on attachment 73277 [details]
Patch

Clearing flags on attachment: 73277

Committed r71610: <http://trac.webkit.org/changeset/71610>
Comment 6 WebKit Commit Bot 2010-11-08 23:48:39 PST
All reviewed patches have been landed.  Closing bug.