Bug 49125 - [EFL] Add option to enable Touch Events.
Summary: [EFL] Add option to enable Touch Events.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-05 22:31 PDT by Ryuan Choi
Modified: 2010-12-24 03:28 PST (History)
6 users (show)

See Also:

Attachments
Patch (14.47 KB, patch)
2010-11-22 22:44 PST, Ryuan Choi 		no flags Details | Formatted Diff | Diff
Updated patch fixing comments of Kenneth (14.47 KB, patch)
2010-11-23 04:54 PST, Ryuan Choi 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2010-11-05 22:31:48 PDT 
[CMake] Add option to enable Touch Events.
Comment 1 Ryuan Choi 2010-11-22 22:44:40 PST 
Created attachment 74633 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2010-11-23 01:01:24 PST 
Comment on attachment 74633 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=74633&action=review

> WebCore/platform/efl/PlatformTouchEventEfl.cpp:36
> +namespace WebCore {
> +PlatformTouchEvent::PlatformTouchEvent(Eina_List* points, const IntPoint pos, TouchEventType type, int metaState)

Shouldn't there be some newline here?

> WebCore/platform/efl/PlatformTouchEventEfl.cpp:68
> +    // FIXME: We don't support metaState now.

'for now'

> WebKit/efl/WebCoreSupport/ChromeClientEfl.h:126
> +#if ENABLE(TOUCH_EVENTS)
> +    virtual void needTouchEvents(bool) { }
> +#endif
> +

What is that bool for?

> WebKit/efl/ewk/ewk_frame.cpp:1481
> +#if ENABLE(TOUCH_EVENTS)

I would add a newline before this one
Comment 3 Ryuan Choi 2010-11-23 04:54:09 PST 
Created attachment 74645 [details]
Updated patch fixing comments of Kenneth
Comment 4 Ryuan Choi 2010-11-23 05:05:27 PST 
(In reply to comment #3)
> Created an attachment (id=74645) [details]
> Updated patch fixing comments of Kenneth

Dear  Kenneth,
Thank you for you reviewing and I fixed all you mentioned.

> > WebKit/efl/WebCoreSupport/ChromeClientEfl.h:126
> > +#if ENABLE(TOUCH_EVENTS)
> > +    virtual void needTouchEvents(bool) { }
> > +#endif
> > +
> 
> What is that bool for?

This function is for WebCore to inform the platform when it needs touch events.
(https://bugs.webkit.org/show_bug.cgi?id=34215)

We probably need this, but not now.
Comment 5 WebKit Commit Bot 2010-12-24 03:28:09 PST 
Comment on attachment 74645 [details]
Updated patch fixing comments of Kenneth

Clearing flags on attachment: 74645

Committed r74626: <http://trac.webkit.org/changeset/74626>
Comment 6 WebKit Commit Bot 2010-12-24 03:28:16 PST 
All reviewed patches have been landed.  Closing bug.