Bug 49125 – [EFL] Add option to enable Touch Events.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Ryuan Choi]

[CMake] Add option to enable Touch Events.

[Ryuan Choi]

Created attachment 74633 [details]
Patch

[Kenneth Rohde Christiansen]

Comment on attachment 74633 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=74633&action=review

> WebCore/platform/efl/PlatformTouchEventEfl.cpp:36
> +namespace WebCore {
> +PlatformTouchEvent::PlatformTouchEvent(Eina_List* points, const IntPoint pos, TouchEventType type, int metaState)

Shouldn't there be some newline here?

> WebCore/platform/efl/PlatformTouchEventEfl.cpp:68
> +    // FIXME: We don't support metaState now.

'for now'

> WebKit/efl/WebCoreSupport/ChromeClientEfl.h:126
> +#if ENABLE(TOUCH_EVENTS)
> +    virtual void needTouchEvents(bool) { }
> +#endif
> +

What is that bool for?

> WebKit/efl/ewk/ewk_frame.cpp:1481
> +#if ENABLE(TOUCH_EVENTS)

I would add a newline before this one

[Ryuan Choi]

Created attachment 74645 [details]
Updated patch fixing comments of Kenneth

[Ryuan Choi]

(In reply to comment #3)
> Created an attachment (id=74645) [details]
> Updated patch fixing comments of Kenneth

Dear  Kenneth,
Thank you for you reviewing and I fixed all you mentioned.

> > WebKit/efl/WebCoreSupport/ChromeClientEfl.h:126
> > +#if ENABLE(TOUCH_EVENTS)
> > +    virtual void needTouchEvents(bool) { }
> > +#endif
> > +
> 
> What is that bool for?

This function is for WebCore to inform the platform when it needs touch events.
(https://bugs.webkit.org/show_bug.cgi?id=34215)

We probably need this, but not now.

[WebKit Commit Bot]

Comment on attachment 74645 [details]
Updated patch fixing comments of Kenneth

Clearing flags on attachment: 74645

Committed r74626: <http://trac.webkit.org/changeset/74626>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.