Bug 49124 - Inline some DeprecatedPtrListImplIterator methods for performance
Summary: Inline some DeprecatedPtrListImplIterator methods for performance
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-05 21:38 PDT by Simon Fraser (smfr)
Modified: 2010-12-20 22:58 PST (History)
3 users (show)

See Also:

Attachments
Patch (3.43 KB, patch)
2010-11-05 21:39 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2010-11-05 21:38:40 PDT 
Inline some DeprecatedPtrListImplIterator methods for performance
Comment 1 Simon Fraser (smfr) 2010-11-05 21:39:15 PDT 
Created attachment 73163 [details]
Patch
Comment 2 Dave Hyatt 2010-11-05 21:40:29 PDT 
Comment on attachment 73163 [details]
Patch

r=me
Comment 3 WebKit Review Bot 2010-11-05 21:42:39 PDT 
Attachment 73163 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebCore/ChangeLog', u'WebCore/platform/DeprecatedPtrListImpl.cpp', u'WebCore/platform/DeprecatedPtrListImpl.h']" exit_code: 1
WebCore/platform/DeprecatedPtrListImpl.h:96:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Eric Seidel (no email) 2010-11-05 21:44:42 PDT 
Attachment 73163 [details] did not build on mac:
Build output: http://queues.webkit.org/results/5302025
Comment 5 Simon Fraser (smfr) 2010-11-05 21:56:19 PDT 
http://trac.webkit.org/changeset/71462
Comment 6 Simon Fraser (smfr) 2010-11-05 22:35:10 PDT 
I backed this out because of weird linker errors.
Comment 8 Eric Seidel (no email) 2010-12-14 01:45:44 PST 
Curious what the status here is.
Comment 9 Simon Fraser (smfr) 2010-12-14 08:32:13 PST 
Replace DeprecatedListPtr use for floats with a <vector> or something else.
Comment 10 Eric Seidel (no email) 2010-12-20 22:56:03 PST 
r71462.  Please close bugs after landing.  webkit-patch land will do this automatically for you. :)
Comment 11 Simon Fraser (smfr) 2010-12-20 22:58:42 PST 
The patch was backed out because of linker issues.