Bug 49119 - Add AudioNode custom bindings
Summary: Add AudioNode custom bindings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-05 17:48 PDT by Chris Rogers
Modified: 2010-11-15 20:54 PST (History)
2 users (show)

See Also:


Attachments
Patch (8.50 KB, patch)
2010-11-05 17:54 PDT, Chris Rogers
no flags Details | Formatted Diff | Diff
Patch (8.52 KB, patch)
2010-11-05 17:57 PDT, Chris Rogers
no flags Details | Formatted Diff | Diff
Patch (8.07 KB, patch)
2010-11-11 15:25 PST, Chris Rogers
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Rogers 2010-11-05 17:48:52 PDT
Add AudioNode custom bindings
Comment 1 Chris Rogers 2010-11-05 17:54:46 PDT
Created attachment 73151 [details]
Patch
Comment 2 Chris Rogers 2010-11-05 17:57:52 PDT
Created attachment 73152 [details]
Patch
Comment 3 Kenneth Russell 2010-11-11 15:00:44 PST
Comment on attachment 73152 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=73152&action=review

Basically looks fine; r- for unnecessary checks.

> WebCore/bindings/js/JSAudioNodeCustom.cpp:42
> +    if (exec->argumentCount() > 3)
> +        return throwError(exec, createSyntaxError(exec, "Too many arguments"));

It isn't an error to pass too many arguments to a JavaScript function.

> WebCore/bindings/js/JSAudioNodeCustom.cpp:68
> +    if (exec->argumentCount() > 1)
> +        return throwError(exec, createSyntaxError(exec, "Too many arguments"));

Unnecessary check per above.

> WebCore/bindings/v8/custom/V8AudioNodeCustom.cpp:45
> +    if (args.Length() > 3)
> +        return throwError("Too many arguments", V8Proxy::SyntaxError);

Unnecessary check per above.

> WebCore/bindings/v8/custom/V8AudioNodeCustom.cpp:77
> +    if (args.Length() > 1)
> +        return throwError("Too many arguments", V8Proxy::SyntaxError);

Unnecessary check per above.
Comment 4 Chris Rogers 2010-11-11 15:25:44 PST
Created attachment 73671 [details]
Patch
Comment 5 Chris Rogers 2010-11-11 15:26:40 PST
Comment on attachment 73152 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=73152&action=review

>> WebCore/bindings/js/JSAudioNodeCustom.cpp:42
>> +        return throwError(exec, createSyntaxError(exec, "Too many arguments"));
> 
> It isn't an error to pass too many arguments to a JavaScript function.

FIXED

>> WebCore/bindings/js/JSAudioNodeCustom.cpp:68
>> +        return throwError(exec, createSyntaxError(exec, "Too many arguments"));
> 
> Unnecessary check per above.

FIXED

>> WebCore/bindings/v8/custom/V8AudioNodeCustom.cpp:45
>> +        return throwError("Too many arguments", V8Proxy::SyntaxError);
> 
> Unnecessary check per above.

FIXED

>> WebCore/bindings/v8/custom/V8AudioNodeCustom.cpp:77
>> +        return throwError("Too many arguments", V8Proxy::SyntaxError);
> 
> Unnecessary check per above.

FIXED
Comment 6 Kenneth Russell 2010-11-15 14:45:09 PST
Comment on attachment 73671 [details]
Patch

Looks good to me.
Comment 7 WebKit Commit Bot 2010-11-15 16:34:24 PST
Comment on attachment 73671 [details]
Patch

Rejecting patch 73671 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'build-and-test', '--no-clean', '--no-update', '--test', '--non-interactive']" exit_code: 2
Last 500 characters of output:
do ...............................
editing/unsupported-content .........
fast/backgrounds ..........................
fast/backgrounds/repeat .......
fast/backgrounds/size ..........................
fast/block/basic ...............................
fast/block/float ...............
fast/block/float/015.html -> failed

Exiting early after 1 failures. 5611 tests run.
97.38s total testing time

5610 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
3 test cases (<1%) had stderr output

Full output: http://queues.webkit.org/results/6051078
Comment 8 Chris Rogers 2010-11-15 20:21:48 PST
putting back in commit queue.  It previously failed on a completely unrelated test.
Comment 9 WebKit Commit Bot 2010-11-15 20:53:57 PST
Comment on attachment 73671 [details]
Patch

Clearing flags on attachment: 73671

Committed r72057: <http://trac.webkit.org/changeset/72057>
Comment 10 WebKit Commit Bot 2010-11-15 20:54:03 PST
All reviewed patches have been landed.  Closing bug.