Bug 49114 - [Qt] make install does not cause JavaScriptCore to be built
Summary: [Qt] make install does not cause JavaScriptCore to be built
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-05 16:52 PDT by Sam Magnuson
Modified: 2010-11-07 19:09 PST (History)
1 user (show)

See Also:


Attachments
patch (1.10 KB, patch)
2010-11-05 17:02 PDT, Sam Magnuson
no flags Details | Formatted Diff | Diff
patch (1.09 KB, patch)
2010-11-05 17:03 PDT, Sam Magnuson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Magnuson 2010-11-05 16:52:58 PDT
When I do a make install at the root directory it will not build JavaScriptCore if there are changes (because libjs is just a .a). I've added an install target just so it will get compiled on a make install.
Comment 1 Sam Magnuson 2010-11-05 17:02:24 PDT
Created attachment 73145 [details]
patch
Comment 2 Sam Magnuson 2010-11-05 17:03:45 PDT
Created attachment 73146 [details]
patch

Remove extraneous / in changelog.
Comment 3 Andreas Kling 2010-11-07 19:07:21 PST
Comment on attachment 73146 [details]
patch

LGTM. This has itched me on occasion, thanks for the fix!
Comment 4 Andreas Kling 2010-11-07 19:08:56 PST
Comment on attachment 73146 [details]
patch

Clearing flags on attachment: 73146

Committed r71489: <http://trac.webkit.org/changeset/71489>
Comment 5 Andreas Kling 2010-11-07 19:09:05 PST
All reviewed patches have been landed.  Closing bug.