Bug 49102 - Stop abusing the style system in order to get RenderLayers for things that need to be composited
Summary: Stop abusing the style system in order to get RenderLayers for things that ne...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-05 15:11 PDT by Simon Fraser (smfr)
Modified: 2023-10-09 09:36 PDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2010-11-05 15:11:51 PDT
We currently make use of synthetic style changes, and code in RenderObject::adjustStyleDifference() to force RenderLayers to get created for elements that need them for compositing (iframes, canvas, plugins).

This has caused problems (see patch in bug 44877). We should instead just make RenderLayers directly somehow.
Comment 1 Ahmad Saleem 2023-10-07 18:29:10 PDT
@Simon - Is this bug still applicable?
Comment 2 Simon Fraser (smfr) 2023-10-09 09:36:02 PDT
We do still do this via invalidateStyleAndLayerComposition(). Doesn't seem particularly bad, though.