Bug 49090 - WebProcess won't kill itself if UIProcess goes away while WebProcess is spinning
Summary: WebProcess won't kill itself if UIProcess goes away while WebProcess is spinning
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords: InRadar, PlatformOnly
Depends on:
Blocks:
 
Reported: 2010-11-05 13:41 PDT by Anders Carlsson
Modified: 2017-10-09 15:34 PDT (History)
2 users (show)

See Also:

Attachments
Patch (19.65 KB, patch)
2010-11-05 14:52 PDT, Anders Carlsson 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2010-11-05 13:41:16 PDT 
WebProcess won't kill itself if UIProcess goes away while WebProcess is spinning
Comment 1 Anders Carlsson 2010-11-05 14:50:50 PDT 
<rdar://problem/7834575>
Comment 2 Anders Carlsson 2010-11-05 14:52:57 PDT 
Created attachment 73123 [details]
Patch
Comment 3 Darin Adler 2010-11-05 15:41:50 PDT 
Comment on attachment 73123 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=73123&action=review

> WebKit2/Platform/CoreIPC/Connection.h:83
> +        virtual void didCloseOnConnectionWorkQueue(WorkQueue*, Connection*) { }

Why not pure virtual?

> WebKit2/Platform/WorkItem.h:174
> +    void execute()

Is this virtual? Could you be explicit about that?
Comment 4 Anders Carlsson 2010-11-05 15:46:24 PDT 
(In reply to comment #3)
> (From update of attachment 73123 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=73123&action=review
> 
> > WebKit2/Platform/CoreIPC/Connection.h:83
> > +        virtual void didCloseOnConnectionWorkQueue(WorkQueue*, Connection*) { }
> 
> Why not pure virtual?

Because it's only used by two clients and I didn't want to force all other connections to add empty functions.

> 
> > WebKit2/Platform/WorkItem.h:174
> > +    void execute()
> 
> Is this virtual? Could you be explicit about that?

Yes and yes.
Comment 5 Anders Carlsson 2010-11-05 16:00:37 PDT 
Committed r71456: <http://trac.webkit.org/changeset/71456>