Bug 49090 – WebProcess won't kill itself if UIProcess goes away while WebProcess is spinning

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Anders Carlsson]

WebProcess won't kill itself if UIProcess goes away while WebProcess is spinning

[Anders Carlsson]

<rdar://problem/7834575>

[Anders Carlsson]

Created attachment 73123 [details]
Patch

[Darin Adler]

Comment on attachment 73123 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=73123&action=review

> WebKit2/Platform/CoreIPC/Connection.h:83
> +        virtual void didCloseOnConnectionWorkQueue(WorkQueue*, Connection*) { }

Why not pure virtual?

> WebKit2/Platform/WorkItem.h:174
> +    void execute()

Is this virtual? Could you be explicit about that?

[Anders Carlsson]

(In reply to comment #3)
> (From update of attachment 73123 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=73123&action=review
> 
> > WebKit2/Platform/CoreIPC/Connection.h:83
> > +        virtual void didCloseOnConnectionWorkQueue(WorkQueue*, Connection*) { }
> 
> Why not pure virtual?

Because it's only used by two clients and I didn't want to force all other connections to add empty functions.

> 
> > WebKit2/Platform/WorkItem.h:174
> > +    void execute()
> 
> Is this virtual? Could you be explicit about that?

Yes and yes.

[Anders Carlsson]

Committed r71456: <http://trac.webkit.org/changeset/71456>