Web Inspector: _bindResourceURL in ResourceManager.js may not add resource to map

[Jenn Braithwaite]

In ResourceManager.js:

    _bindResourceURL: function(resource)
    {
        var resourceForURL = this._resourcesByURL[resource.url];
        if (!resourceForURL)
            this._resourcesByURL[resource.url] = resource;
        else if (resourceForURL instanceof Array)
            resourceForURL.push(resource);
        else
            this._resourcesByURL[resource.url] = [resourceForURL];   <====
    },

The last else clause converts a single element into an array, but it seems to have forgotten to put the resource into the newly formed array.

[Jenn Braithwaite]

Created attachment 73105 [details]
patch

[Pavel Feldman]

Comment on attachment 73105 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=73105&action=review

Thanks for fixing this!
Fyi: there is a webkit.com/new-inspector-bug that has nice template for inspector bugs.

> WebCore/ChangeLog:5
> +        _bindResourceURL in ResourceManager.js may not add resource to map

You should use Web Inspector: prefix

> WebCore/inspector/front-end/ResourceManager.js:405
> +            var resourceForURLArray = [resourceForURL];

Nit: I would simply do

this._resourcesByURL[resource.url] = [resourceForURL, resource];

[Jenn Braithwaite]

Created attachment 73246 [details]
updated patch

I like your JS better. My JS-newbie-ness is showing...

[WebKit Commit Bot]

Comment on attachment 73246 [details]
updated patch

Clearing flags on attachment: 73246

Committed r71603: <http://trac.webkit.org/changeset/71603>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.