Bug 49082 - [EFL] Change the usage of eina_iterator_next due to latest EFL changes.
Summary: [EFL] Change the usage of eina_iterator_next due to latest EFL changes.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Rafael Antognolli
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-05 11:32 PDT by Rafael Antognolli
Modified: 2010-11-08 13:01 PST (History)
7 users (show)

See Also:

Attachments
Patch (2.16 KB, patch)
2010-11-05 11:35 PDT, Rafael Antognolli 		no flags Details | Formatted Diff | Diff
Patch (2.18 KB, patch)
2010-11-05 11:45 PDT, Rafael Antognolli 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Antognolli 2010-11-05 11:32:57 PDT 
[EFL] Change the usage of eina_iterator_next due to latest EFL changes.
Comment 1 Rafael Antognolli 2010-11-05 11:35:02 PDT 
Created attachment 73090 [details]
Patch
Comment 2 Antonio Gomes 2010-11-05 11:38:48 PDT 
Comment on attachment 73090 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=73090&action=review

> WebKit/efl/ChangeLog:8
> +        https://bugs.webkit.org/show_bug.cgi?id=49082
> +
> +		A change on how the iterator for a tiler is used in EFL needs to be

Fix indentation, please.
Comment 3 WebKit Review Bot 2010-11-05 11:39:14 PDT 
Attachment 73090 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebKit/efl/ChangeLog', u'WebKit/efl/ewk/ewk_view_single.c']" exit_code: 1
WebKit/efl/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
WebKit/efl/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
WebKit/efl/ChangeLog:10:  Line contains tab character.  [whitespace/tab] [5]
WebKit/efl/ChangeLog:11:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 4 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Rafael Antognolli 2010-11-05 11:45:58 PDT 
Created attachment 73094 [details]
Patch
Comment 5 Leandro Pereira 2010-11-08 12:57:02 PST 
Comment on attachment 73094 [details]
Patch

I'll land the patch manually, since this'll break the build temporarily. Removing cq+.
Comment 6 Leandro Pereira 2010-11-08 13:00:51 PST 
Comment on attachment 73094 [details]
Patch

Clearing flags on attachment: 73094

Committed r71561: <http://trac.webkit.org/changeset/71561>
Comment 7 Leandro Pereira 2010-11-08 13:01:00 PST 
All reviewed patches have been landed.  Closing bug.