Bug 49078 – [Chromium] fast/events/stopPropagation-submit.html fails

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Mihai Parparita]

[Chromium] fast/events/stopPropagation-submit.html fails

[Mihai Parparita]

Created attachment 73084 [details]
Patch

[Ojan Vafai]

Comment on attachment 73084 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=73084&action=review

> LayoutTests/ChangeLog:16
> +        * FWIW, it looks like GURL is right, per step 15 of section 4.10.22.3 
> +        (Form submission algorithm) of the HTML 5, data URLs used with GET
> +        should not be mutated.

Please file a bug for this. Either KURL should be changed or GURL/HTML5 should be.

> LayoutTests/fast/events/stopPropagation-submit.html:3
>  see a link below and the text FAIL. On success you will see PASS (and

This description doesn't seem to be correct. I don't see anywhere that FAIL would get printed out. Mind fixing that while you're modifying this test?

[Mihai Parparita]

(In reply to comment #2)
> (From update of attachment 73084 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=73084&action=review
> 
> > LayoutTests/ChangeLog:16
> > +        * FWIW, it looks like GURL is right, per step 15 of section 4.10.22.3 
> > +        (Form submission algorithm) of the HTML 5, data URLs used with GET
> > +        should not be mutated.
> 
> Please file a bug for this. Either KURL should be changed or GURL/HTML5 should be.

Filed bug bug 49091 about this.
 
> > LayoutTests/fast/events/stopPropagation-submit.html:3
> >  see a link below and the text FAIL. On success you will see PASS (and
> 
> This description doesn't seem to be correct. I don't see anywhere that FAIL would get printed out. Mind fixing that while you're modifying this test?

FAIL is included at line 10, if the test fails (and stopPropagation prevents form submission) then the original page's text will be dumped.

Will upload a new patch anyway so that there's a reference to bug 49091 in the ChangeLog.

[Mihai Parparita]

Created attachment 73114 [details]
Patch

[Ojan Vafai]

Comment on attachment 73114 [details]
Patch

Oh, sorry, I missed the FAIL line.

[WebKit Commit Bot]

Comment on attachment 73114 [details]
Patch

Clearing flags on attachment: 73114

Committed r71450: <http://trac.webkit.org/changeset/71450>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.