Bug 49078 - [Chromium] fast/events/stopPropagation-submit.html fails
Summary: [Chromium] fast/events/stopPropagation-submit.html fails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Mihai Parparita
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-05 10:56 PDT by Mihai Parparita
Modified: 2010-11-05 14:41 PDT (History)
2 users (show)

See Also:

Attachments
Patch (3.61 KB, patch)
2010-11-05 11:00 PDT, Mihai Parparita 		no flags Details | Formatted Diff | Diff
Patch (3.70 KB, patch)
2010-11-05 14:05 PDT, Mihai Parparita 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mihai Parparita 2010-11-05 10:56:51 PDT 
[Chromium] fast/events/stopPropagation-submit.html fails
Comment 1 Mihai Parparita 2010-11-05 11:00:26 PDT 
Created attachment 73084 [details]
Patch
Comment 2 Ojan Vafai 2010-11-05 13:25:33 PDT 
Comment on attachment 73084 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=73084&action=review

> LayoutTests/ChangeLog:16
> +        * FWIW, it looks like GURL is right, per step 15 of section 4.10.22.3 
> +        (Form submission algorithm) of the HTML 5, data URLs used with GET
> +        should not be mutated.

Please file a bug for this. Either KURL should be changed or GURL/HTML5 should be.

> LayoutTests/fast/events/stopPropagation-submit.html:3
>  see a link below and the text FAIL. On success you will see PASS (and

This description doesn't seem to be correct. I don't see anywhere that FAIL would get printed out. Mind fixing that while you're modifying this test?
Comment 3 Mihai Parparita 2010-11-05 14:01:23 PDT 
(In reply to comment #2)
> (From update of attachment 73084 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=73084&action=review
> 
> > LayoutTests/ChangeLog:16
> > +        * FWIW, it looks like GURL is right, per step 15 of section 4.10.22.3 
> > +        (Form submission algorithm) of the HTML 5, data URLs used with GET
> > +        should not be mutated.
> 
> Please file a bug for this. Either KURL should be changed or GURL/HTML5 should be.

Filed bug bug 49091 about this.
 
> > LayoutTests/fast/events/stopPropagation-submit.html:3
> >  see a link below and the text FAIL. On success you will see PASS (and
> 
> This description doesn't seem to be correct. I don't see anywhere that FAIL would get printed out. Mind fixing that while you're modifying this test?

FAIL is included at line 10, if the test fails (and stopPropagation prevents form submission) then the original page's text will be dumped.

Will upload a new patch anyway so that there's a reference to bug 49091 in the ChangeLog.
Comment 4 Mihai Parparita 2010-11-05 14:05:16 PDT 
Created attachment 73114 [details]
Patch
Comment 5 Ojan Vafai 2010-11-05 14:20:11 PDT 
Comment on attachment 73114 [details]
Patch

Oh, sorry, I missed the FAIL line.
Comment 6 WebKit Commit Bot 2010-11-05 14:41:36 PDT 
Comment on attachment 73114 [details]
Patch

Clearing flags on attachment: 73114

Committed r71450: <http://trac.webkit.org/changeset/71450>
Comment 7 WebKit Commit Bot 2010-11-05 14:41:41 PDT 
All reviewed patches have been landed.  Closing bug.