Bug 49067 – Convert SVGPoint/SVGPointList to the new SVGPropertyTearOff concept

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Nikolas Zimmermann]

Convert SVGPoint/SVGPointList to the new SVGPropertyTearOff concept.

[Nikolas Zimmermann]

Created attachment 73057 [details]
Patch

Uploading a preliminary patch, yet missing the LayoutTests/ changes, and the ChangeLogs.
I only want to get some early EWS results, as I'm leaving soon.

[Nikolas Zimmermann]

Created attachment 73058 [details]
Patch v2

Updated to trunk, now the patch should apply.

[Eric Seidel (no email)]

Attachment 73058 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/5352001

[Dirk Schulze]

I thought you have a chromium build on your machine, why does every first patch of yours fail on chromium? ;-)

[Nikolas Zimmermann]

(In reply to comment #4)
> I thought you have a chromium build on your machine, why does every first patch of yours fail on chromium? ;-)

I don't test every patch on chromium unless I'm adding new functionality, like StrictTypeChecking etc. that was not implemented on Chromium and had to be tested. If this patch compiles, it will work on V8, as the code is 1:1 equal to JSC.

[WebKit Review Bot]

Attachment 73058 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/5295018

[Nikolas Zimmermann]

Created attachment 73222 [details]
Patch v3

Complete patch including ChangeLogs and LayoutTests changes. Only difference to "Patch v2" are CodeGeneratorV8.pm changes, to make it build on chromium/v8.

[Dirk Schulze]

Comment on attachment 73222 [details]
Patch v3

r=me. The solution with SVGAnimatedPoints is still a bit sad. We should discuss it on www-svg to change it in the Spec as well. Maybe we can move it into SVG1.1se? Anyway, it doesn't block this patch since it doesn't affect anything on the user side, with the exception that it runs faster. Please update the win proj file before landing.

[Nikolas Zimmermann]

(In reply to comment #8)
> (From update of attachment 73222 [details])
> r=me. The solution with SVGAnimatedPoints is still a bit sad. We should discuss it on www-svg to change it in the Spec as well. Maybe we can move it into SVG1.1se? Anyway, it doesn't block this patch since it doesn't affect anything on the user side, with the exception that it runs faster. Please update the win proj file before landing.

Synced the vcproj to trunk before landing, now it should work as expected.
Thanks for the review!

Landed in r71512.

[Nikolas Zimmermann]

Trying to fix windows build in r71514. A warning was produced.

[Simon Fraser (smfr)]

@@ -21385,7 +21372,6 @@
 			isa = PBXProject;
 			buildConfigurationList = 149C284308902B11008A9EFC /* Build configuration list for PBXProject "WebCore" */;
 			compatibilityVersion = "Xcode 2.4";
-			developmentRegion = English;
 			hasScannedForEncodings = 1;
 			knownRegions = (

Please update to Xcode 3.2.4 so this change does not happen.

[Nikolas Zimmermann]

(In reply to comment #11)
> @@ -21385,7 +21372,6 @@
>              isa = PBXProject;
>              buildConfigurationList = 149C284308902B11008A9EFC /* Build configuration list for PBXProject "WebCore" */;
>              compatibilityVersion = "Xcode 2.4";
> -            developmentRegion = English;
>              hasScannedForEncodings = 1;
>              knownRegions = (
> 
> Please update to Xcode 3.2.4 so this change does not happen.

Aww, I'm sorry, forgot to remove the offending line :(
AFAIK there's no XCode 3.2.4 for Leopard, which is still my main dev platform?