Bug 49049 - Could review tool include style failure info?
Summary: Could review tool include style failure info?
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2010-11-04 20:38 PDT by Oliver Hunt
Modified: 2011-01-20 16:59 PST (History)
3 users (show)

See Also:

Patch (2.74 KB, patch)
2011-01-20 16:48 PST, Ojan Vafai
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2010-11-04 20:38:49 PDT
I was just reviewing a patch that made the style bot go red for bogus reasons, it was annoying to have to go away and look at a separate page to identify whether the errors were indeed correct.  It would be awesome if the style failures could be displayed inline in the review tool
Comment 1 Eric Seidel (no email) 2010-11-04 20:40:12 PDT
Woh, crazy talk.  Should be quite easy to do, I think.
Comment 2 Adam Barth 2010-11-05 10:20:28 PDT
Yeah, I was planning to do this originally, but never got around to it.  We just need to write a parser for the style queue output, which shouldn't be that hard.
Comment 3 Ojan Vafai 2011-01-20 16:48:41 PST
Created attachment 79666 [details]
Comment 4 Ojan Vafai 2011-01-20 16:59:04 PST
Committed r76310: <http://trac.webkit.org/changeset/76310>