Bug 49044 - cleanup style in TestNetscapePlugIn/PluginObject.cpp
Summary: cleanup style in TestNetscapePlugIn/PluginObject.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-04 18:15 PDT by Tony Chang
Modified: 2010-11-05 12:38 PDT (History)
4 users (show)

See Also:

Attachments
Patch (14.20 KB, patch)
2010-11-04 18:16 PDT, Tony Chang 		no flags Details | Formatted Diff | Diff
Patch (19.91 KB, patch)
2010-11-05 09:53 PDT, Tony Chang 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2010-11-04 18:15:48 PDT 
cleanup style in TestNetscapePlugIn/PluginTest.cpp
Comment 1 Tony Chang 2010-11-04 18:16:58 PDT 
Created attachment 73022 [details]
Patch
Comment 2 Tony Chang 2010-11-04 18:17:48 PDT 
Mostly just converting "else if" with early returns into separate "if" statements.
Comment 3 Kent Tamura 2010-11-04 18:48:44 PDT 
Comment on attachment 73022 [details]
Patch

check-webkit-style shows other errors for PluginObject.cpp.  Would you like to fix them too?
Comment 4 Tony Chang 2010-11-05 09:53:35 PDT 
Created attachment 73073 [details]
Patch
Comment 5 Tony Chang 2010-11-05 09:54:27 PDT 
Comment on attachment 73073 [details]
Patch

The only remaining error is about config.h, which doesn't apply here.
Comment 6 WebKit Commit Bot 2010-11-05 12:37:57 PDT 
Comment on attachment 73073 [details]
Patch

Clearing flags on attachment: 73073

Committed r71443: <http://trac.webkit.org/changeset/71443>
Comment 7 WebKit Commit Bot 2010-11-05 12:38:03 PDT 
All reviewed patches have been landed.  Closing bug.