Bug 49017 - Title for images should use localized numerals
Summary: Title for images should use localized numerals
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.6
: P2 Normal
Assignee: Mike Thole
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-04 12:50 PDT by Mike Thole
Modified: 2010-11-04 13:04 PDT (History)
0 users

See Also:

Attachments
Proposed patch (9.81 KB, patch)
2010-11-04 12:52 PDT, Mike Thole 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Thole 2010-11-04 12:50:33 PDT 
The page title displayed when viewing an image (e.g. "MyImage.jpg 20x20 pixels") should use localized numerals.
Comment 1 Mike Thole 2010-11-04 12:52:14 PDT 
Created attachment 72973 [details]
Proposed patch
Comment 2 mitz 2010-11-04 13:01:15 PDT 
Comment on attachment 72973 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=72973&action=review

> WebKit/mac/WebCoreSupport/WebPlatformStrategies.mm:666
> +    return [NSString localizedStringWithFormat:UI_STRING("%@ %@Ã%@ pixels", "window title for a standalone image (uses multiplication symbol, not x)"), (NSString *)filename, widthString, heightString];

Perhaps the localizer comment should mention that the first argument is a filename (the may be helpful to localizers trying to decide what bidi embedding characters to use and where).
Comment 3 Mike Thole 2010-11-04 13:04:27 PDT 
Committed revision 71353.