Bug 49004 - Enable running of Qt API tests on BuildBot
Summary: Enable running of Qt API tests on BuildBot
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2010-11-04 09:23 PDT by Gabor Rapcsanyi
Modified: 2010-11-09 07:19 PST (History)
3 users (show)

See Also:

proposed patch (2.86 KB, patch)
2010-11-04 09:34 PDT, Gabor Rapcsanyi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Rapcsanyi 2010-11-04 09:23:19 PDT
Run Qt API tests on Qt slaves.
Comment 1 Gabor Rapcsanyi 2010-11-04 09:34:06 PDT
Created attachment 72949 [details]
proposed patch

It's running now on our x86 bots at http://webkit.sed.hu/buildbot/waterfall with this config.
Comment 2 Csaba Osztrogonác 2010-11-05 15:51:43 PDT
Comment on attachment 72949 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=72949&action=review

Otherwise LGTM, r=me with these changes.
Bill, could you execute a reconfigure on buildbot master after this patch landed?

> WebKitTools/BuildSlaveSupport/build.webkit.org-config/master.cfg:337
> +    def evaluateCommand(self, cmd):
> +        if self.incorrectLines:
> +            return FAILURE

Qt API tests are quite stable, but I think 
we shouldn't block the bots if it fails.

I prefer using WARNINGS instead of FAILURE.

> WebKitTools/BuildSlaveSupport/build.webkit.org-config/master.cfg:342
> +        if cmd.rc != 0:
> +            return FAILURE
> +
> +        return SUCCESS

Comment 3 Csaba Osztrogonác 2010-11-08 04:11:55 PST
Landed in http://trac.webkit.org/changeset/71509

Bill, could you reconfigure the buildbot master, please?
Comment 4 William Siegrist 2010-11-08 08:40:51 PST
Master restart started.
Comment 5 Csaba Osztrogonác 2010-11-09 07:19:32 PST
(In reply to comment #4)
> Master restart started.

Thx, it works now. ;)