Bug 48974 - Use leakRef instead of releaseRef
Summary: Use leakRef instead of releaseRef
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-03 21:39 PDT by Xan Lopez
Modified: 2010-11-04 18:17 PDT (History)
1 user (show)

See Also:


Attachments
leakref.diff (15.38 KB, patch)
2010-11-03 21:44 PDT, Xan Lopez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Xan Lopez 2010-11-03 21:39:18 PDT
SSIA.
Comment 1 Xan Lopez 2010-11-03 21:44:32 PDT
Created attachment 72903 [details]
leakref.diff
Comment 2 Adam Barth 2010-11-04 14:07:21 PDT
Comment on attachment 72903 [details]
leakref.diff

Can you add more information to the ChangeLog as to why?
Comment 3 Xan Lopez 2010-11-04 14:56:10 PDT
(In reply to comment #2)
> (From update of attachment 72903 [details])
> Can you add more information to the ChangeLog as to why?

Like explain why it's deprecated or?
Comment 4 Xan Lopez 2010-11-04 18:17:41 PDT
Comment on attachment 72903 [details]
leakref.diff

Ok, I added an extra sentence explaining why the rename happened in the first place, hope that's enough.

FWIW, the rename wasn't explained in the commit where leakRef happened (reviewed by a "Adam Barth" ;)), so I just went to the original mailing list thread.
Comment 5 Xan Lopez 2010-11-04 18:17:58 PDT
Closing bug.