RESOLVED FIXED 48956
Implement NP_SetProperty 
https://bugs.webkit.org/show_bug.cgi?id=48956
Summary Implement NP_SetProperty
Anders Carlsson
Reported 2010-11-03 14:47:32 PDT
Implement NP_SetProperty
Attachments
Patch (7.23 KB, patch)
2010-11-03 14:49 PDT, Anders Carlsson 		aroben: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2010-11-03 14:49:45 PDT
Created attachment 72875 [details] Patch
WebKit Review Bot
Comment 2 2010-11-03 14:51:46 PDT
Attachment 72875 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/platform/mac-wk2/Skipped', u'WebKit2/ChangeLog', u'WebKit2/Shared/Plugins/NPObjectMessageReceiver.cpp', u'WebKit2/Shared/Plugins/NPObjectMessageReceiver.h', u'WebKit2/Shared/Plugins/NPObjectMessageReceiver.messages.in', u'WebKit2/Shared/Plugins/NPObjectProxy.cpp', u'WebKit2/Shared/Plugins/NPObjectProxy.h']" exit_code: 1 WebKit2/Shared/Plugins/NPObjectProxy.cpp:237: NPObjectProxy::NP_SetProperty is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Adam Roben (:aroben)
Comment 3 2010-11-03 14:53:07 PDT
Comment on attachment 72875 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=72875&action=review > WebKit2/Shared/Plugins/NPObjectMessageReceiver.cpp:142 > + // And release the value. > + releaseNPVariantValue(&propertyValue); Makes me think we should have a smart pointer for NPVariant.
Anders Carlsson
Comment 4 2010-11-03 14:55:20 PDT
Committed r71273: <http://trac.webkit.org/changeset/71273>
Note You need to log in before you can comment on or make changes to this bug.