Bug 48956 - Implement NP_SetProperty
Summary: Implement NP_SetProperty
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-03 14:47 PDT by Anders Carlsson
Modified: 2010-11-03 14:55 PDT (History)
1 user (show)

See Also:

Attachments
Patch (7.23 KB, patch)
2010-11-03 14:49 PDT, Anders Carlsson 		aroben: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2010-11-03 14:47:32 PDT 
Implement NP_SetProperty
Comment 1 Anders Carlsson 2010-11-03 14:49:45 PDT 
Created attachment 72875 [details]
Patch
Comment 2 WebKit Review Bot 2010-11-03 14:51:46 PDT 
Attachment 72875 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/platform/mac-wk2/Skipped', u'WebKit2/ChangeLog', u'WebKit2/Shared/Plugins/NPObjectMessageReceiver.cpp', u'WebKit2/Shared/Plugins/NPObjectMessageReceiver.h', u'WebKit2/Shared/Plugins/NPObjectMessageReceiver.messages.in', u'WebKit2/Shared/Plugins/NPObjectProxy.cpp', u'WebKit2/Shared/Plugins/NPObjectProxy.h']" exit_code: 1
WebKit2/Shared/Plugins/NPObjectProxy.cpp:237:  NPObjectProxy::NP_SetProperty is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Adam Roben (:aroben) 2010-11-03 14:53:07 PDT 
Comment on attachment 72875 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=72875&action=review

> WebKit2/Shared/Plugins/NPObjectMessageReceiver.cpp:142
> +    // And release the value.
> +    releaseNPVariantValue(&propertyValue);

Makes me think we should have a smart pointer for NPVariant.
Comment 4 Anders Carlsson 2010-11-03 14:55:20 PDT 
Committed r71273: <http://trac.webkit.org/changeset/71273>