Bug 48944 – Ignore children of text field controls in the accessibility tree.

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Chris Guillory]

Chromium needs to receive an accessibility notification when the RenderText::setText is called. Currently AccessibilityRenderObject::contentChanged doesn't post an accessibility notification.

[Chris Guillory]

Created attachment 72869 [details]
Send a value changed notification in contentsChanged.

[chris fleizach]

Comment on attachment 72869 [details]
Send a value changed notification in contentsChanged.

the value change your looking for should get sent in

RenderTextControl::setInnerTextValue

can you see if that does what you need. 

regardless, i don't think you want to send one in contentsChanged() which can be triggered on things that might not actually be considered contents changed

[Chris Guillory]

RenderTextControl::setInnerTextValue posts an AXValueChanged notification but the control has children:

RenderTextControlSingleLine
  RenderTextControlInnerBlock
    RenderText

Chromium correctly updates the text of the RenderTextControlSingleLine node but not the RenderText node (which has the same text). Does one of these sound like a good approach:
(1) In Chromium, ignore the children of the RenderTextControl in the accessibility tree.
(2) In Chromium, send AXValueChanged from RenderText::setText.

[chris fleizach]

(In reply to comment #3)
> RenderTextControl::setInnerTextValue posts an AXValueChanged notification but the control has children:
> 
> RenderTextControlSingleLine
>   RenderTextControlInnerBlock
>     RenderText
> 
> Chromium correctly updates the text of the RenderTextControlSingleLine node but not the RenderText node (which has the same text). Does one of these sound like a good approach:
> (1) In Chromium, ignore the children of the RenderTextControl in the accessibility tree.

I would say the children of a RenderTextControl should be ignored. usually that info is conveyed through other means

> (2) In Chromium, send AXValueChanged from RenderText::setText.

[chris fleizach]

In Chromium, ignore the children of the RenderTextControl in the accessibility tree.
> 
> I would say the children of a RenderTextControl should be ignored. usually that info is conveyed through other means
> 

for example, NSAccessibilityValueAttribute on Mac

[Chris Guillory]

Created attachment 72884 [details]
Ignore children of text field controls in the accessibility tree.

[chris fleizach]

Comment on attachment 72884 [details]
Ignore children of text field controls in the accessibility tree.

i thought about doing it this way too, but then occasionally text fields have "X" buttons in them for clearing things out. this may not be the case on the web yet, but it seems like a possible future.
it might be better to make the RenderText object inside a RenderTextControl be accessibilityIgnored

[Chris Guillory]

Created attachment 72887 [details]
Ignore static text children of text field controls in the accessibility tree.

[chris fleizach]

Comment on attachment 72887 [details]
Ignore static text children of text field controls in the accessibility tree.

this might be more inclusive with something like

if (parentObjectUnignored()->roleValue() == TextFieldRole)

that way if you're making a text area with aria (<div role='textbox'>) it won't erroneously report the child element either.

[Chris Guillory]

Created attachment 72892 [details]
Using roleValue

For the RenderTextControl case the RenderText's parent is a RenderTextControlInnerBlock which has the Group role so I still have to loop to check additional parents. Maybe we should ignore the RenderTextControlInnerBlock renderer also.

[chris fleizach]

Comment on attachment 72892 [details]
Using roleValue

looks good

[chris fleizach]

(In reply to comment #10)
> Created an attachment (id=72892) [details]
> Using roleValue
> 
> For the RenderTextControl case the RenderText's parent is a RenderTextControlInnerBlock which has the Group role so I still have to loop to check additional parents. Maybe we should ignore the RenderTextControlInnerBlock renderer also.

RenderTextControlInnerBlock should be ignored already i imagine. i've never seen it appear in the AX tree

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 72892 [details]:

webarchive/test-link-rel-icon.html

Please file bugs against the tests.  These tests were authored by [e-mail].  The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 72892 [details]
Using roleValue

Clearing flags on attachment: 72892

Committed r71317: <http://trac.webkit.org/changeset/71317>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.