RESOLVED FIXED 48938
Remove IMPLEMENTATION_COLOR_READ_FORMAT and TYPE 
https://bugs.webkit.org/show_bug.cgi?id=48938
Summary Remove IMPLEMENTATION_COLOR_READ_FORMAT and TYPE
Kenneth Russell
Reported 2010-11-03 11:36:45 PDT
Per discussion on the public WebGL mailing list, the alternate format/type to readPixels defined by queries of the IMPLEMENTATION_COLOR_READ_FORMAT and IMPLEMENTATION_COLOR_READ_TYPE has been removed. These enums need to be removed from the WebKit implementation and tests updated.
Attachments
patch (16.86 KB, patch)
2010-11-04 12:34 PDT, Zhenyao Mo 		kbr: review-
zmo: commit-queue-
DetailsFormatted DiffDiff
revised patch: responding to kbr's review (18.99 KB, patch)
2010-11-04 17:13 PDT, Zhenyao Mo 		kbr: review-
zmo: commit-queue-
DetailsFormatted DiffDiff
revised patch: updated the change logs (19.16 KB, patch)
2010-11-04 17:22 PDT, Zhenyao Mo 		kbr: review+
zmo: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Zhenyao Mo
Comment 1 2010-11-04 12:34:31 PDT
Created attachment 72971 [details] patch
Kenneth Russell
Comment 2 2010-11-04 16:48:05 PDT
Comment on attachment 72971 [details] patch You need to remove these constants from WebGLRenderingContext.idl as well. Please also add a test to webgl-specific.html that gl.IMPLEMENTATION_COLOR_READ_FORMAT and gl.IMPLEMENTATION_COLOR_READ_TYPE are both undefined.
Zhenyao Mo
Comment 3 2010-11-04 17:13:43 PDT
Created attachment 73009 [details] revised patch: responding to kbr's review Will update khronos test once this patch is reviewed.
Kenneth Russell
Comment 4 2010-11-04 17:14:28 PDT
Comment on attachment 73009 [details] revised patch: responding to kbr's review Please update the ChangeLogs.
Zhenyao Mo
Comment 5 2010-11-04 17:22:43 PDT
Created attachment 73011 [details] revised patch: updated the change logs
Kenneth Russell
Comment 6 2010-11-04 17:39:48 PDT
Comment on attachment 73011 [details] revised patch: updated the change logs Looks good.
Zhenyao Mo
Comment 7 2010-11-04 17:55:22 PDT
Committed r71372: <http://trac.webkit.org/changeset/71372>
Zhenyao Mo
Comment 8 2010-11-04 18:00:25 PDT
khronos test updated.
Note You need to log in before you can comment on or make changes to this bug.