RESOLVED FIXED Bug 48920
[Web Timing] Split domContentLoaded into start/end 
https://bugs.webkit.org/show_bug.cgi?id=48920
Summary [Web Timing] Split domContentLoaded into start/end
Tony Gentilcore
Reported 2010-11-03 09:31:23 PDT
domContentLoaded is now domContentLoadedEventStart and domContentLoadedEventEnd (to match loadEventStart/End and unloadEventStart/End). Details: http://dvcs.w3.org/hg/webperf/rev/7900c0da4484
Attachments
Patch (15.26 KB, patch)
2010-11-08 16:45 PST, James Simonsen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Simonsen
Comment 1 2010-11-08 16:45:12 PST
Created attachment 73306 [details] Patch
Tony Gentilcore
Comment 2 2010-11-08 17:15:45 PST
LGTM!
Dimitri Glazkov (Google)
Comment 3 2010-11-08 18:59:24 PST
Comment on attachment 73306 [details] Patch ok
WebKit Commit Bot
Comment 4 2010-11-08 21:46:30 PST
Comment on attachment 73306 [details] Patch Rejecting patch 73306 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'apply-attachment', '--force-clean', '--non-interactive', 73306]" exit_code: 1 Traceback (most recent call last): File "./WebKitTools/Scripts/webkit-patch", line 70, in <module> main() File "./WebKitTools/Scripts/webkit-patch", line 63, in main from webkitpy.tool.main import WebKitPatch File "/Users/abarth/git/webkit-queue/WebKitTools/Scripts/webkitpy/tool/main.py", line 42, in <module> from webkitpy.common.net.rietveld import Rietveld ImportError: No module named rietveld Full output: http://queues.webkit.org/results/5524032
WebKit Commit Bot
Comment 5 2010-11-08 23:02:45 PST
Comment on attachment 73306 [details] Patch Clearing flags on attachment: 73306 Committed r71608: <http://trac.webkit.org/changeset/71608>
WebKit Commit Bot
Comment 6 2010-11-08 23:02:50 PST
All reviewed patches have been landed. Closing bug.
Mihai Parparita
Comment 7 2010-11-09 07:55:45 PST
BTW, this broke fast/dom/Window/window-properties-performance.html (should be fixed with http://trac.webkit.org/changeset/71633).
Tony Gentilcore
Comment 8 2010-11-09 09:26:32 PST
(In reply to comment #7) > BTW, this broke fast/dom/Window/window-properties-performance.html (should be fixed with http://trac.webkit.org/changeset/71633). Thanks for the fix!
James Simonsen
Comment 9 2010-11-09 10:31:07 PST
(In reply to comment #7) > BTW, this broke fast/dom/Window/window-properties-performance.html (should be fixed with http://trac.webkit.org/changeset/71633). Thanks for the fix. Sorry about breaking it. I should've caught that.
Note You need to log in before you can comment on or make changes to this bug.