Bug 48920 - [Web Timing] Split domContentLoaded into start/end
Summary: [Web Timing] Split domContentLoaded into start/end
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 30685 48922
  Show dependency tree / graph
 
Reported: 2010-11-03 09:31 PDT by Tony Gentilcore
Modified: 2010-11-09 10:31 PST (History)
4 users (show)

See Also:

Attachments
Patch (15.26 KB, patch)
2010-11-08 16:45 PST, James Simonsen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Gentilcore 2010-11-03 09:31:23 PDT 
domContentLoaded is now domContentLoadedEventStart and domContentLoadedEventEnd (to match loadEventStart/End and unloadEventStart/End).

Details: http://dvcs.w3.org/hg/webperf/rev/7900c0da4484
Comment 1 James Simonsen 2010-11-08 16:45:12 PST 
Created attachment 73306 [details]
Patch
Comment 2 Tony Gentilcore 2010-11-08 17:15:45 PST 
LGTM!
Comment 3 Dimitri Glazkov (Google) 2010-11-08 18:59:24 PST 
Comment on attachment 73306 [details]
Patch

ok
Comment 4 WebKit Commit Bot 2010-11-08 21:46:30 PST 
Comment on attachment 73306 [details]
Patch

Rejecting patch 73306 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'apply-attachment', '--force-clean', '--non-interactive', 73306]" exit_code: 1
Traceback (most recent call last):
  File "./WebKitTools/Scripts/webkit-patch", line 70, in <module>
    main()
  File "./WebKitTools/Scripts/webkit-patch", line 63, in main
    from webkitpy.tool.main import WebKitPatch
  File "/Users/abarth/git/webkit-queue/WebKitTools/Scripts/webkitpy/tool/main.py", line 42, in <module>
    from webkitpy.common.net.rietveld import Rietveld
ImportError: No module named rietveld

Full output: http://queues.webkit.org/results/5524032
Comment 5 WebKit Commit Bot 2010-11-08 23:02:45 PST 
Comment on attachment 73306 [details]
Patch

Clearing flags on attachment: 73306

Committed r71608: <http://trac.webkit.org/changeset/71608>
Comment 6 WebKit Commit Bot 2010-11-08 23:02:50 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Mihai Parparita 2010-11-09 07:55:45 PST 
BTW, this broke fast/dom/Window/window-properties-performance.html (should be fixed with http://trac.webkit.org/changeset/71633).
Comment 8 Tony Gentilcore 2010-11-09 09:26:32 PST 
(In reply to comment #7)
> BTW, this broke fast/dom/Window/window-properties-performance.html (should be fixed with http://trac.webkit.org/changeset/71633).

Thanks for the fix!
Comment 9 James Simonsen 2010-11-09 10:31:07 PST 
(In reply to comment #7)
> BTW, this broke fast/dom/Window/window-properties-performance.html (should be fixed with http://trac.webkit.org/changeset/71633).

Thanks for the fix. Sorry about breaking it. I should've caught that.