Bug 48919 - [Web Timing] Rename interfaces
Summary: [Web Timing] Rename interfaces
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 30685 48922
  Show dependency treegraph
 
Reported: 2010-11-03 09:23 PDT by Tony Gentilcore
Modified: 2010-11-12 14:51 PST (History)
9 users (show)

See Also:


Attachments
Patch (44.16 KB, patch)
2010-11-08 14:37 PST, James Simonsen
no flags Details | Formatted Diff | Diff
Patch (93.77 KB, patch)
2010-11-08 15:28 PST, James Simonsen
no flags Details | Formatted Diff | Diff
Patch (95.20 KB, patch)
2010-11-08 15:54 PST, James Simonsen
no flags Details | Formatted Diff | Diff
Patch (95.55 KB, patch)
2010-11-09 17:44 PST, James Simonsen
no flags Details | Formatted Diff | Diff
Patch (97.67 KB, patch)
2010-11-11 16:14 PST, James Simonsen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Gentilcore 2010-11-03 09:23:31 PDT
Currently Web Timing has 3 interfaces:
Performance
  +- Timing
  +- Navigation

These have just been renamed in the spec to:
Performance
  +- PerformanceTiming
  +- PerformanceNavigation

We should rename WebCore/page/Timing to WebCore/page/PerformanceTiming and WebCore/page/Navigation to WebCore/page/PerformanceNavigation.

Details: http://dvcs.w3.org/hg/webperf/rev/5d546ada8927
Comment 1 James Simonsen 2010-11-08 14:37:29 PST
Created attachment 73288 [details]
Patch
Comment 2 Tony Gentilcore 2010-11-08 14:41:14 PST
This looks correct to me. Dimitri might be able to r+.
Comment 3 WebKit Review Bot 2010-11-08 14:48:31 PST
Attachment 73288 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/5559041
Comment 4 Early Warning System Bot 2010-11-08 14:50:24 PST
Attachment 73288 [details] did not build on qt:
Build output: http://queues.webkit.org/results/5548035
Comment 5 James Simonsen 2010-11-08 15:28:02 PST
Created attachment 73293 [details]
Patch

Manually created patch. webkit-patch ignored the renamed files.
Comment 6 Early Warning System Bot 2010-11-08 15:36:10 PST
Attachment 73293 [details] did not build on qt:
Build output: http://queues.webkit.org/results/5529040
Comment 7 James Simonsen 2010-11-08 15:54:59 PST
Created attachment 73299 [details]
Patch
Comment 8 James Simonsen 2010-11-09 17:44:56 PST
Created attachment 73448 [details]
Patch

Merged with other WebTiming changes from yesterday.

I think this is ready to go in. I fixed the issues with Qt and GTK and they're both green now.
Comment 9 James Simonsen 2010-11-11 16:14:41 PST
Created attachment 73677 [details]
Patch

Updated for EFL and Android.
Comment 10 James Simonsen 2010-11-12 13:47:54 PST
This has an LGTM. Can I get an R+? Thanks.
Comment 11 WebKit Commit Bot 2010-11-12 14:51:47 PST
Comment on attachment 73677 [details]
Patch

Clearing flags on attachment: 73677

Committed r71951: <http://trac.webkit.org/changeset/71951>
Comment 12 WebKit Commit Bot 2010-11-12 14:51:53 PST
All reviewed patches have been landed.  Closing bug.