Bug 48915 – Web Inspector: show proper image size for cached resources.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Feldman]

Patch to follow.

[Pavel Feldman]

Created attachment 72820 [details]
[PATCH] Proposed change.

[Andrey Kosyakov]

Comment on attachment 72820 [details]
[PATCH] Proposed change.

View in context: https://bugs.webkit.org/attachment.cgi?id=72820&action=review

> WebCore/inspector/front-end/ImageView.js:79
> +                var resourceSize = this.resource.resourceSize;

Wouldn't it be more readable with a ternary operator?

> WebCore/inspector/front-end/ImageView.js:101
> +    _base64ToSize: function(content)

This is rather generic, I would consider moving this to utilities.js or making it a member of Resource.

> WebCore/inspector/front-end/ImageView.js:105
> +        var size = (content.length || 0) * 3 / 4;

content.length || 0 seems to be redundant considering the above line.

> WebCore/inspector/front-end/ImageView.js:107
> +            size--;

ditto.

[Simon Fraser (smfr)]

Comment on attachment 72820 [details]
[PATCH] Proposed change.

View in context: https://bugs.webkit.org/attachment.cgi?id=72820&action=review

> WebCore/ChangeLog:9
> +        https://bugs.webkit.org/show_bug.cgi?id=48915
> +
> +        * inspector/front-end/ExtensionServer.js:
> +        (WebInspector.ExtensionServer.prototype._onGetResourceContent):

I'd like to see some explanation of what the problem was and how you fixed it here.

[Pavel Feldman]

(In reply to comment #3)
> (From update of attachment 72820 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=72820&action=review
> 
> > WebCore/ChangeLog:9
> > +        https://bugs.webkit.org/show_bug.cgi?id=48915
> > +
> > +        * inspector/front-end/ExtensionServer.js:
> > +        (WebInspector.ExtensionServer.prototype._onGetResourceContent):
> 
> I'd like to see some explanation of what the problem was and how you fixed it here.

The problem was that resourceSize for cached resources is 0 and I calculate it from the actual image object instead. And height is a drive-by fix via using naturalHeight.

[Pavel Feldman]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
        M       WebCore/ChangeLog
        M       WebCore/inspector/front-end/ExtensionServer.js
        M       WebCore/inspector/front-end/ImageView.js
        M       WebCore/inspector/front-end/NetworkPanel.js
        M       WebCore/inspector/front-end/Resource.js
        M       WebCore/inspector/front-end/ResourceManager.js
        M       WebCore/inspector/front-end/SourceView.js
Committed r71254