Bug 48907 – Make it possible to delegate scrolling to the UI

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Kenneth Rohde Christiansen]

This is needed for client using a tiled scrolling implementation and thus delegating scrolling to the ui. In WebKit2 this is even more important as this cannot be implemented using the platformWidget().

[Kenneth Rohde Christiansen]

Created attachment 72815 [details]
Patch

This is basically a clean up version of the patch that I showed Hyatt on irc yesterday:

<kenneth> dhyatt, proof of concept, feel free to comment: http://qt.pastebin.com/GHtt6xqM
<dhyatt> kenneth: yeah that looks pretty good

[Andreas Kling]

Comment on attachment 72815 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=72815&action=review

r=me

> WebCore/page/FrameView.h:79
> +    virtual bool delegateScrolling();

I think we should call it shouldDelegateScrolling() here as well.

[Kenneth Rohde Christiansen]

(In reply to comment #2)
> (From update of attachment 72815 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=72815&action=review
> 
> r=me
> 
> > WebCore/page/FrameView.h:79
> > +    virtual bool delegateScrolling();
> 
> I think we should call it shouldDelegateScrolling() here as well.

Everythign in FrameView and ScrollView is that way, like paintsEntireContents, avoidScrollbarCreation, etc.

[Andreas Kling]

(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 72815 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=72815&action=review
> > 
> > r=me
> > 
> > > WebCore/page/FrameView.h:79
> > > +    virtual bool delegateScrolling();
> > 
> > I think we should call it shouldDelegateScrolling() here as well.
> 
> Everythign in FrameView and ScrollView is that way, like paintsEntireContents, avoidScrollbarCreation, etc.

delegatesScrolling() then? *bikesheds*
I just don't like the imperative sound of "delegate scrolling."

[Andreas Kling]

Committed r71239: <http://trac.webkit.org/changeset/71239>