WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
48901
Web Inspector: brush up breakpoints UI and UX.
https://bugs.webkit.org/show_bug.cgi?id=48901
Summary
Web Inspector: brush up breakpoints UI and UX.
Pavel Feldman
Reported
2010-11-03 02:11:52 PDT
- Numerous style improvements - Start editing XHR on double click - Do not convert entire DOM breakpoint into a link - Render DOM breakpoints on two rows - etc.
Attachments
[IMAGE] Screenshot while running with patch (1).
(124.77 KB, image/png)
2010-11-03 02:13 PDT
,
Pavel Feldman
no flags
Details
[IMAGE] Screenshot while running with patch (2).
(102.92 KB, image/png)
2010-11-03 02:13 PDT
,
Pavel Feldman
no flags
Details
[PATCH] Proposed fix.
(14.26 KB, patch)
2010-11-03 02:18 PDT
,
Pavel Feldman
jorlow
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Pavel Feldman
Comment 1
2010-11-03 02:13:30 PDT
Created
attachment 72797
[details]
[IMAGE] Screenshot while running with patch (1).
Pavel Feldman
Comment 2
2010-11-03 02:13:50 PDT
Created
attachment 72798
[details]
[IMAGE] Screenshot while running with patch (2).
Pavel Feldman
Comment 3
2010-11-03 02:18:45 PDT
Created
attachment 72799
[details]
[PATCH] Proposed fix.
Pavel Podivilov
Comment 4
2010-11-03 04:00:59 PDT
Looks good.
Jeremy Orlow
Comment 5
2010-11-03 04:21:22 PDT
Comment on
attachment 72799
[details]
[PATCH] Proposed fix. rubber stamp = me
Pavel Feldman
Comment 6
2010-11-03 06:49:24 PDT
Committing to
http://svn.webkit.org/repository/webkit/trunk
... M WebCore/ChangeLog M WebCore/inspector/front-end/BreakpointManager.js M WebCore/inspector/front-end/BreakpointsSidebarPane.js M WebCore/inspector/front-end/ElementsTreeOutline.js M WebCore/inspector/front-end/inspector.css Committed
r71234
Joseph Pecoraro
Comment 7
2010-11-03 09:10:21 PDT
Comment on
attachment 72799
[details]
[PATCH] Proposed fix. View in context:
https://bugs.webkit.org/attachment.cgi?id=72799&action=review
> WebCore/inspector/front-end/inspector.css:4102 > - margin: 4px 0; > - color: rgb(33%, 33%, 33%); > - cursor: pointer; > + padding: 2px 0; > + color: black;
What cursor is used for the breakpoint-list? As long as it isn't the ibar!
> WebCore/inspector/front-end/inspector.css:4396 > \ No newline at end of file >
It's announcing it =).
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug