Bug 48901 - Web Inspector: brush up breakpoints UI and UX.
Summary: Web Inspector: brush up breakpoints UI and UX.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-03 02:11 PDT by Pavel Feldman
Modified: 2010-11-03 09:10 PDT (History)
11 users (show)

See Also:

Attachments
[IMAGE] Screenshot while running with patch (1). (124.77 KB, image/png)
2010-11-03 02:13 PDT, Pavel Feldman 		no flags Details
[IMAGE] Screenshot while running with patch (2). (102.92 KB, image/png)
2010-11-03 02:13 PDT, Pavel Feldman 		no flags Details
[PATCH] Proposed fix. (14.26 KB, patch)
2010-11-03 02:18 PDT, Pavel Feldman 		jorlow: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2010-11-03 02:11:52 PDT 
- Numerous style improvements
- Start editing XHR on double click
- Do not convert entire DOM breakpoint into a link
- Render DOM breakpoints on two rows
- etc.
Comment 1 Pavel Feldman 2010-11-03 02:13:30 PDT 
Created attachment 72797 [details]
[IMAGE] Screenshot while running with patch (1).
Comment 2 Pavel Feldman 2010-11-03 02:13:50 PDT 
Created attachment 72798 [details]
[IMAGE] Screenshot while running with patch (2).
Comment 3 Pavel Feldman 2010-11-03 02:18:45 PDT 
Created attachment 72799 [details]
[PATCH] Proposed fix.
Comment 4 Pavel Podivilov 2010-11-03 04:00:59 PDT 
Looks good.
Comment 5 Jeremy Orlow 2010-11-03 04:21:22 PDT 
Comment on attachment 72799 [details]
[PATCH] Proposed fix.

rubber stamp = me
Comment 6 Pavel Feldman 2010-11-03 06:49:24 PDT 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
        M       WebCore/ChangeLog
        M       WebCore/inspector/front-end/BreakpointManager.js
        M       WebCore/inspector/front-end/BreakpointsSidebarPane.js
        M       WebCore/inspector/front-end/ElementsTreeOutline.js
        M       WebCore/inspector/front-end/inspector.css
Committed r71234
Comment 7 Joseph Pecoraro 2010-11-03 09:10:21 PDT 
Comment on attachment 72799 [details]
[PATCH] Proposed fix.

View in context: https://bugs.webkit.org/attachment.cgi?id=72799&action=review

> WebCore/inspector/front-end/inspector.css:4102
> -    margin: 4px 0;
> -    color: rgb(33%, 33%, 33%);
> -    cursor: pointer;
> +    padding: 2px 0;
> +    color: black;

What cursor is used for the breakpoint-list? As long as it isn't the ibar!

> WebCore/inspector/front-end/inspector.css:4396
>  \ No newline at end of file
>  

It's announcing it =).