Bug 48898 - Convert SVGAnimatedString/SVGStringList to the new SVG*PropertyTearOff concept
Summary: Convert SVGAnimatedString/SVGStringList to the new SVG*PropertyTearOff concept
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nikolas Zimmermann
Depends on:
Blocks: 40887 47905
  Show dependency treegraph
Reported: 2010-11-03 00:38 PDT by Nikolas Zimmermann
Modified: 2010-11-03 05:15 PDT (History)
2 users (show)

See Also:

Patch (103.61 KB, patch)
2010-11-03 02:47 PDT, Nikolas Zimmermann
krit: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2010-11-03 00:38:21 PDT
Convert SVGAnimatedString/SVGStringList to the new SVG*PropertyTearOff concept. Soon we're done with these changes!

Once this is done the bug 40887 "requiredFeatures does not adapt to SVGStringList changes" can be fixed in a proper way, w/o the need to add custom list code for JSC/V8.
Comment 1 Nikolas Zimmermann 2010-11-03 02:47:13 PDT
Created attachment 72804 [details]
Comment 2 Dirk Schulze 2010-11-03 04:08:33 PDT
Comment on attachment 72804 [details]

Looks great. r=me
Comment 3 Nikolas Zimmermann 2010-11-03 04:15:07 PDT
Landed in r71227. Unfortunately EWS is not checking this patch, nor any other patch today, so I'm praying it works on all platforms, let's see. Closing the bug, after I got results.
Comment 4 Nikolas Zimmermann 2010-11-03 04:23:25 PDT
Landed chromium/v8 build fix in r71229.
Comment 5 Nikolas Zimmermann 2010-11-03 04:34:15 PDT
Landed next chromium/v8 build fix in r71230.
Comment 6 Nikolas Zimmermann 2010-11-03 05:15:49 PDT
Ok, I gave up and tried a local chromium ToT build. Now CodeGeneratorV8 is fixed...
Landed final fix in r71232.