Bug 48890 – Undo r54932 which inappropriately adjusts font sizes on zoomed pages

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tony Chang]

Undo r54932 which inappropriately adjusts font sizes on zoomed pages

[Tony Chang]

Created attachment 72776 [details]
Patch

[Erik Arvidsson]

Comment on attachment 72776 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=72776&action=review

> LayoutTests/editing/pasteboard/page-zoom2.html:26
> +        document.getElementById("target").innerHTML.toString();

innerHTML is already a string

[Ryosuke Niwa]

Comment on attachment 72776 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=72776&action=review

> LayoutTests/editing/pasteboard/page-zoom2.html:23
> +    execPasteCommand();

Doesn't document.execCommand("insertHTML", false, "<span style="font-size: 16px" id="test">This font is size 16px.</span>") also work?

[Ojan Vafai]

Comment on attachment 72776 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=72776&action=review

Removing paste hacks is awesome! The copy-paste code is far too complicated.

> LayoutTests/editing/pasteboard/page-zoom2.html:15
> +        eventSender.zoomPageIn();

I think you can just set CSS zoom on the body element and get the same effect. That way, you don't need to zoom out at the end and this test is closer to being able to run in other browsers. It also simplifies running the test manualy.

[Tony Chang]

Committed r71252: <http://trac.webkit.org/changeset/71252>

[Tony Chang]

(In reply to comment #5)
> Committed r71252: <http://trac.webkit.org/changeset/71252>

Before landing I made the following test changes:
- Removed toString() calls and used local variables for nodes.
- Switched to insertHTML (had to fake an apple style span)
- Used css zoom instead.
- Moved the test to editing/inserting since it no longer involved pasting.