Bug 48869 - [Qt] Adding iphone user agent string the user agent list for QtTestBrowser
Summary: [Qt] Adding iphone user agent string the user agent list for QtTestBrowser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-02 14:01 PDT by Leonid Ebril
Modified: 2011-01-03 05:29 PST (History)
3 users (show)

See Also:


Attachments
adding user agent string for iphone 4 to the useragentlist.txt (3.11 KB, patch)
2010-11-02 15:13 PDT, Leonid Ebril
kling: review-
Details | Formatted Diff | Diff
an updated version of patch (using Unix newlines, rather than CRLF). (1.69 KB, patch)
2010-11-03 06:14 PDT, Leonid Ebril
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Leonid Ebril 2010-11-02 14:01:51 PDT
This change will simplify testing/debugging iphone specific use cases on QtTestBrowser.
Comment 1 Leonid Ebril 2010-11-02 15:13:48 PDT
Created attachment 72749 [details]
adding user agent string for iphone 4 to the useragentlist.txt 

added user agent string for iphone 4
Comment 2 WebKit Review Bot 2010-11-02 15:16:58 PDT
Attachment 72749 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebKitTools/ChangeLog', u'WebKitTools/QtTestBrowser/useragentlist.txt']" exit_code: 1
WebKitTools/QtTestBrowser/useragentlist.txt:1:  One or more unexpected \r (^M) found; better to use only a \n  [whitespace/carriage_return] [1]
Suppressing further [whitespace/carriage_return] reports for this file.
Total errors found: 10 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2010-11-03 00:55:10 PDT
Comment on attachment 72749 [details]
adding user agent string for iphone 4 to the useragentlist.txt 

The change is fine, but the patch should be using Unix newlines, rather than CRLF.
Comment 4 Leonid Ebril 2010-11-03 06:14:02 PDT
Created attachment 72816 [details]
an updated version of patch (using Unix newlines, rather than CRLF).
Comment 5 Andreas Kling 2010-11-04 05:01:42 PDT
Comment on attachment 72816 [details]
an updated version of patch (using Unix newlines, rather than CRLF).

r=me
Comment 6 WebKit Commit Bot 2010-11-04 05:29:20 PDT
Comment on attachment 72816 [details]
an updated version of patch (using Unix newlines, rather than CRLF).

Clearing flags on attachment: 72816

Committed r71325: <http://trac.webkit.org/changeset/71325>
Comment 7 WebKit Commit Bot 2010-11-04 05:29:25 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Ademar Reis 2011-01-03 05:26:54 PST
Revision r71325 cherry-picked into qtwebkit-2.2 with commit 7a3db1d <http://gitorious.org/webkit/qtwebkit/commit/7a3db1d>
Comment 9 Ademar Reis 2011-01-03 05:29:36 PST
Has just been cherry-picked to qtwebkit-2.2, removing blockage.