RESOLVED FIXED 48869
[Qt] Adding iphone user agent string the user agent list for QtTestBrowser 
https://bugs.webkit.org/show_bug.cgi?id=48869
Summary [Qt] Adding iphone user agent string the user agent list for QtTestBrowser
Leonid Ebril
Reported 2010-11-02 14:01:51 PDT
This change will simplify testing/debugging iphone specific use cases on QtTestBrowser.
Attachments
adding user agent string for iphone 4 to the useragentlist.txt (3.11 KB, patch)
2010-11-02 15:13 PDT, Leonid Ebril 		kling: review-
DetailsFormatted DiffDiff
an updated version of patch (using Unix newlines, rather than CRLF). (1.69 KB, patch)
2010-11-03 06:14 PDT, Leonid Ebril 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Leonid Ebril
Comment 1 2010-11-02 15:13:48 PDT
Created attachment 72749 [details] adding user agent string for iphone 4 to the useragentlist.txt added user agent string for iphone 4
WebKit Review Bot
Comment 2 2010-11-02 15:16:58 PDT
Attachment 72749 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebKitTools/ChangeLog', u'WebKitTools/QtTestBrowser/useragentlist.txt']" exit_code: 1 WebKitTools/QtTestBrowser/useragentlist.txt:1: One or more unexpected \r (^M) found; better to use only a \n [whitespace/carriage_return] [1] Suppressing further [whitespace/carriage_return] reports for this file. Total errors found: 10 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 3 2010-11-03 00:55:10 PDT
Comment on attachment 72749 [details] adding user agent string for iphone 4 to the useragentlist.txt The change is fine, but the patch should be using Unix newlines, rather than CRLF.
Leonid Ebril
Comment 4 2010-11-03 06:14:02 PDT
Created attachment 72816 [details] an updated version of patch (using Unix newlines, rather than CRLF).
Andreas Kling
Comment 5 2010-11-04 05:01:42 PDT
Comment on attachment 72816 [details] an updated version of patch (using Unix newlines, rather than CRLF). r=me
WebKit Commit Bot
Comment 6 2010-11-04 05:29:20 PDT
Comment on attachment 72816 [details] an updated version of patch (using Unix newlines, rather than CRLF). Clearing flags on attachment: 72816 Committed r71325: <http://trac.webkit.org/changeset/71325>
WebKit Commit Bot
Comment 7 2010-11-04 05:29:25 PDT
All reviewed patches have been landed. Closing bug.
Ademar Reis
Comment 8 2011-01-03 05:26:54 PST
Revision r71325 cherry-picked into qtwebkit-2.2 with commit 7a3db1d <http://gitorious.org/webkit/qtwebkit/commit/7a3db1d>
Ademar Reis
Comment 9 2011-01-03 05:29:36 PST
Has just been cherry-picked to qtwebkit-2.2, removing blockage.
Note You need to log in before you can comment on or make changes to this bug.