WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
48864
Add some support for remote and local NPObjects to NPRemoteObjectMap
https://bugs.webkit.org/show_bug.cgi?id=48864
Summary
Add some support for remote and local NPObjects to NPRemoteObjectMap
Anders Carlsson
Reported
2010-11-02 13:09:28 PDT
Add some support for remote and local NPObjects to NPRemoteObjectMap
Attachments
Patch
(7.35 KB, patch)
2010-11-02 13:13 PDT
,
Anders Carlsson
aroben
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2010-11-02 13:13:08 PDT
Created
attachment 72724
[details]
Patch
Adam Roben (:aroben)
Comment 2
2010-11-02 13:17:08 PDT
Comment on
attachment 72724
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=72724&action=review
> WebKit2/Shared/Plugins/NPVariantData.cpp:109 > + // We special case LocalNPObjectID and RemoteNPObjectID here so a LocalNPObjectID is > + // encoded as a RemoteNPObjectID and vice versa.
Should be "special-case" and "decoded", not "special case" and "encoded". Maybe you could explain a little more, saying that the encoded type is from the perspective of the other process, so we have to adjust it to match our own perspective?
Anders Carlsson
Comment 3
2010-11-02 13:26:06 PDT
Committed
r71156
: <
http://trac.webkit.org/changeset/71156
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug