Bug 48864 - Add some support for remote and local NPObjects to NPRemoteObjectMap
Summary: Add some support for remote and local NPObjects to NPRemoteObjectMap
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-02 13:09 PDT by Anders Carlsson
Modified: 2010-11-02 13:26 PDT (History)
0 users

See Also:

Attachments
Patch (7.35 KB, patch)
2010-11-02 13:13 PDT, Anders Carlsson 		aroben: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2010-11-02 13:09:28 PDT 
Add some support for remote and local NPObjects to NPRemoteObjectMap
Comment 1 Anders Carlsson 2010-11-02 13:13:08 PDT 
Created attachment 72724 [details]
Patch
Comment 2 Adam Roben (:aroben) 2010-11-02 13:17:08 PDT 
Comment on attachment 72724 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=72724&action=review

> WebKit2/Shared/Plugins/NPVariantData.cpp:109
> +    // We special case LocalNPObjectID and RemoteNPObjectID here so a LocalNPObjectID is
> +    // encoded as a RemoteNPObjectID and vice versa.

Should be "special-case" and "decoded", not "special case" and "encoded". Maybe you could explain a little more, saying that the encoded type is from the perspective of the other process, so we have to adjust it to match our own perspective?
Comment 3 Anders Carlsson 2010-11-02 13:26:06 PDT 
Committed r71156: <http://trac.webkit.org/changeset/71156>