RESOLVED FIXED 48847
More NPRuntime work 
https://bugs.webkit.org/show_bug.cgi?id=48847
Summary More NPRuntime work
Anders Carlsson
Reported 2010-11-02 10:02:09 PDT
More NPRuntime work
Attachments
Patch (20.24 KB, patch)
2010-11-02 10:09 PDT, Anders Carlsson 		aroben: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2010-11-02 10:09:53 PDT
Created attachment 72694 [details] Patch
Adam Roben (:aroben)
Comment 2 2010-11-02 10:18:54 PDT
Comment on attachment 72694 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=72694&action=review > WebKit2/Shared/Plugins/NPObjectMessageReceiver.cpp:54 > NPObjectMessageReceiver::~NPObjectMessageReceiver() > { > + m_npRemoteObjectMap->unregisterNPObject(m_npObjectID); > + What guarantees the map hasn't been destroyed by this point? > WebKit2/Shared/Plugins/NPVariantData.cpp:46 > +NPVariantData NPVariantData::makeVoid() > { > - notImplemented(); > - return false; > + NPVariantData npVariantData; > + > + return npVariantData; > +} How about: return NPVariantData();
Anders Carlsson
Comment 3 2010-11-02 10:20:21 PDT
(In reply to comment #2) > (From update of attachment 72694 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=72694&action=review > > > WebKit2/Shared/Plugins/NPObjectMessageReceiver.cpp:54 > > NPObjectMessageReceiver::~NPObjectMessageReceiver() > > { > > + m_npRemoteObjectMap->unregisterNPObject(m_npObjectID); > > + > > What guarantees the map hasn't been destroyed by this point? Nothing! I'll add a FIXME. > > > WebKit2/Shared/Plugins/NPVariantData.cpp:46 > > +NPVariantData NPVariantData::makeVoid() > > { > > - notImplemented(); > > - return false; > > + NPVariantData npVariantData; > > + > > + return npVariantData; > > +} > > How about: return NPVariantData(); Sure.
Anders Carlsson
Comment 4 2010-11-02 10:26:52 PDT
Committed r71127: <http://trac.webkit.org/changeset/71127>
Note You need to log in before you can comment on or make changes to this bug.