Bug 48844 - Make RenderStyle::playState() return typed value and cleanup naming in Animation code"
Summary: Make RenderStyle::playState() return typed value and cleanup naming in Animat...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Chris Marrin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-02 09:46 PDT by Chris Marrin
Modified: 2010-11-02 10:21 PDT (History)
0 users

See Also:


Attachments
Patch (10.28 KB, patch)
2010-11-02 09:51 PDT, Chris Marrin
aroben: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Marrin 2010-11-02 09:46:34 PDT
Make RenderStyle::playState() return typed value and cleanup naming in Animation code"
Comment 1 Chris Marrin 2010-11-02 09:51:39 PDT
Created attachment 72689 [details]
Patch
Comment 2 Adam Roben (:aroben) 2010-11-02 09:56:39 PDT
Comment on attachment 72689 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=72689&action=review

> WebCore/page/animation/CompositeAnimation.h:102
> -    bool m_isSuspended;
> +    bool m_suspended;

I think this is a step in the wrong direction, but I guess consistency is a good thing.

> WebCore/platform/animation/Animation.h:137
> -    unsigned m_playState     : 2;
> +    EAnimPlayState m_playState     : 2;

You need to keep this an unsigned bitfield. Enum bitfields are signed under MSVC, and that will screw up comparison operations. You should cast to EAnimPlayState in the getter.
Comment 3 Chris Marrin 2010-11-02 10:21:14 PDT
Made change suggested by Adam and landed in http://trac.webkit.org/changeset/71125