Bug 48843 – Web Inspector: [Chromium] Profiling must survive navigation

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Mikhail Naganov]

From crbug/60998:

What steps will reproduce the problem?
1. Navigate to www.google.com
2. Open inspector(Ctrl+Shift+I) and go to Profile tab
3. Start profiling
4. Reload the page
5. Stop profiling

What is the expected output? 
Profile should be present

What do you see instead?
Profile is not visible

----

Also, it would be nice to resume profiling when navigation leads to a page from other domain.

[Mikhail Naganov]

Created attachment 72688 [details]
proposed patch

[WebKit Review Bot]

Attachment 72688 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/inspector/InspectorProfilerAgent.cpp:207:  More than one command on the same line in if  [whitespace/parens] [4]
WebCore/inspector/InspectorProfilerAgent.cpp:226:  More than one command on the same line in if  [whitespace/parens] [4]
Total errors found: 2 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Early Warning System Bot]

Attachment 72688 [details] did not build on qt:
Build output: http://queues.webkit.org/results/4980018

[Mikhail Naganov]

Created attachment 72811 [details]
fix style and qt errors

[Mikhail Naganov]

Created attachment 72826 [details]
profiles list in Inspector is now cleaned up on any reload, this simplifies code a lot

[Adam Barth]

Comment on attachment 72826 [details]
profiles list in Inspector is now cleaned up on any reload, this simplifies code a lot

View in context: https://bugs.webkit.org/attachment.cgi?id=72826&action=review

Lack of tests => sadness

> WebCore/inspector/InspectorController.cpp:677
> -void InspectorController::restoreProfiler()
> +void InspectorController::restoreProfiler(bool reset)

Consider using an enum rather than a bool here to make the call sites more readable.

[Csaba Osztrogonác]

http://trac.webkit.org/changeset/71511 broke Qt minimal build:
../../../WebCore/inspector/InspectorController.cpp:241: error: ‘startUserInitiatedProfiling’ was not declared in this scope

Using of startUserInitiatedProfiling must be guarded 
by ENABLE(JAVASCRIPT_DEBUGGER) as its declaration.

Could you fix it?

[Mikhail Naganov]

Manually committed as http://trac.webkit.org/changeset/71511 + r71513


2010-11-08  Mikhail Naganov  <[e-mail]>

        Reviewed by Adam Barth.

        Web Inspector [Chromium]: Make CPU profiling to survive navigation.

        https://bugs.webkit.org/show_bug.cgi?id=48843

        * inspector/Inspector.idl:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::restoreInspectorStateFromCookie):
        (WebCore::InspectorController::reuseFrontend):
        (WebCore::InspectorController::disconnectFrontend):
        (WebCore::InspectorController::populateScriptObjects):
        (WebCore::InspectorController::restoreProfiler):
        (WebCore::InspectorController::didCommitLoad):
        (WebCore::InspectorController::startUserInitiatedProfiling):
        (WebCore::InspectorController::stopUserInitiatedProfiling):
        * inspector/InspectorController.h:
        (WebCore::InspectorController::startProfiling):
        (WebCore::InspectorController::stopProfiling):
        * inspector/InspectorProfilerAgent.cpp:
        (WebCore::InspectorProfilerAgent::startUserInitiatedProfiling):
        (WebCore::InspectorProfilerAgent::stopUserInitiatedProfiling):
        * inspector/InspectorProfilerAgent.h:
        * inspector/InspectorState.cpp:
        (WebCore::InspectorState::InspectorState):
        * inspector/InspectorState.h:
        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel.prototype.hasTemporaryProfile):
        (WebInspector.ProfilesPanel.prototype.hasProfile):
        * inspector/front-end/inspector.js:
        (WebInspector.setRecordingProfile):