Bug 48841 - Remove special handling of HashTableDeletedValue in PlatformRefPtr and manually manage memory that cannot be controlled by HashTraits
Summary: Remove special handling of HashTableDeletedValue in PlatformRefPtr and manual...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-02 08:55 PDT by Martin Robinson
Modified: 2010-11-02 12:20 PDT (History)
2 users (show)

See Also:


Attachments
Patch for this issue (14.25 KB, patch)
2010-11-02 11:45 PDT, Martin Robinson
xan.lopez: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2010-11-02 08:55:40 PDT
https://bugs.webkit.org/show_bug.cgi?id=46794 introduced handling of HashTableDeletedValue into the smart point directly. This was incorrect. Instead, in places where class members track whether or not their parent has been deleted from a hash table, use manual memory management for those members.
Comment 1 Martin Robinson 2010-11-02 11:45:06 PDT
Created attachment 72707 [details]
Patch for this issue
Comment 2 Xan Lopez 2010-11-02 11:56:48 PDT
Comment on attachment 72707 [details]
Patch for this issue

Makes sense.
Comment 3 Martin Robinson 2010-11-02 12:20:57 PDT
Committed r71148: <http://trac.webkit.org/changeset/71148>