Bug 48839 - Web Inspector: display frame names in the resources panel.
Summary: Web Inspector: display frame names in the resources panel.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-02 08:44 PDT by Pavel Feldman
Modified: 2010-11-02 12:06 PDT (History)
11 users (show)

See Also:

Attachments
[PATCH] Proposed change. (17.22 KB, patch)
2010-11-02 08:48 PDT, Pavel Feldman 		timothy: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2010-11-02 08:44:14 PDT 
Patch to follow.
Comment 1 Pavel Feldman 2010-11-02 08:48:34 PDT 
Created attachment 72673 [details]
[PATCH] Proposed change.
Comment 2 Timothy Hatcher 2010-11-02 11:15:52 PDT 
Comment on attachment 72673 [details]
[PATCH] Proposed change.

View in context: https://bugs.webkit.org/attachment.cgi?id=72673&action=review

> WebCore/inspector/front-end/ResourceManager.js:487
> +        var tmpResource = new WebInspector.Resource(null, frame.url);

Would be better just to factor out displayName so you don't need to make a Resource.

> WebCore/inspector/front-end/StoragePanel.js:863
> +                subtitleElement.textContent = "(" + subtitle + ")";

Why the ()? Screenshot?
Comment 3 Pavel Feldman 2010-11-02 12:01:36 PDT 
I will factor out displayName into resource manager. But so far it is using lastPathComponent parsing that is not so eary to extract (it uses Resource's field).

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/Inspector.idl
	M	WebCore/inspector/InspectorResourceAgent.cpp
	M	WebCore/inspector/InspectorResourceAgent.h
	M	WebCore/inspector/front-end/ResourceManager.js
	M	WebCore/inspector/front-end/StoragePanel.js
	M	WebCore/inspector/front-end/inspector.css
Committed r71144