Bug 48836 - [Chromium] Disable incremental linking for webkit_unit_test and DumpRenderTRee on x86 Windows on chromium build.
Summary: [Chromium] Disable incremental linking for webkit_unit_test and DumpRenderTRe...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-02 08:05 PDT by Marc-Antoine Ruel
Modified: 2010-11-02 15:36 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.36 KB, patch)
2010-11-02 08:09 PDT, Marc-Antoine Ruel
no flags Details | Formatted Diff | Diff
Patch (2.36 KB, patch)
2010-11-02 08:10 PDT, Marc-Antoine Ruel
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marc-Antoine Ruel 2010-11-02 08:05:50 PDT
Disable incremental linking for webkit_unit_test and DumpRenderTRee on x86 Windows on chromium build.

It fails to link otherwise due to lack of virtual address space.
Comment 1 Marc-Antoine Ruel 2010-11-02 08:09:07 PDT
Created attachment 72667 [details]
Patch
Comment 2 Marc-Antoine Ruel 2010-11-02 08:10:50 PDT
Created attachment 72668 [details]
Patch
Comment 3 Marc-Antoine Ruel 2010-11-02 08:12:47 PDT
Please set c+.

Tests now link on Windows XP slave:
http://build.chromium.org/p/tryserver.chromium/builders/win_layout/builds/57
Comment 4 Marc-Antoine Ruel 2010-11-02 08:14:01 PDT
Please set c+.

Tests now link on Windows XP slave:
http://build.chromium.org/p/tryserver.chromium/builders/win_layout/builds/57
Comment 5 WebKit Commit Bot 2010-11-02 15:05:21 PDT
The commit-queue encountered the following flaky tests while processing attachment 72668 [details]:

transitions/transition-end-event-transform.html
http/tests/appcache/foreign-fallback.html

Please file bugs against the tests.  These tests were authored by ap@webkit.org, dino@apple.com, ojan@chromium.org, and pol@apple.com.  The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2010-11-02 15:35:57 PDT
Comment on attachment 72668 [details]
Patch

Clearing flags on attachment: 72668

Committed r71179: <http://trac.webkit.org/changeset/71179>
Comment 7 WebKit Commit Bot 2010-11-02 15:36:02 PDT
All reviewed patches have been landed.  Closing bug.