Bug 48835 - Unused class: JSFastMath with JSValue64
Summary: Unused class: JSFastMath with JSValue64
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other All
: P2 Trivial
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-02 07:08 PDT by Gabor Loki
Modified: 2010-11-03 01:22 PDT (History)
3 users (show)

See Also:


Attachments
remove JSFastMath class (5.88 KB, patch)
2010-11-02 07:11 PDT, Gabor Loki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Loki 2010-11-02 07:08:13 PDT
There is an unused class in JSImmediate.h: JSFastMath. It can be safely removed.
Comment 1 Gabor Loki 2010-11-02 07:11:26 PDT
Created attachment 72661 [details]
remove JSFastMath class
Comment 2 Geoffrey Garen 2010-11-02 08:02:04 PDT
Comment on attachment 72661 [details]
remove JSFastMath class

r=me
Comment 3 WebKit Commit Bot 2010-11-02 15:28:44 PDT
Comment on attachment 72661 [details]
remove JSFastMath class

Rejecting patch 72661 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'build-and-test', '--no-clean', '--no-update', '--test', '--non-interactive']" exit_code: 2
Last 500 characters of output:
.....
fast/tokenizer ........................................
fast/transforms .......................
fast/url ....................
fast/workers .............................................
fast/workers/storage ..........................
fast/workers/storage/use-same-database-in-page-and-workers.html -> failed

Exiting early after 1 failures. 16101 tests run.
502.96s total testing time

16100 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
5 test cases (<1%) had stderr output

Full output: http://queues.webkit.org/results/4930021
Comment 4 Gabor Loki 2010-11-03 00:24:07 PDT
Comment on attachment 72661 [details]
remove JSFastMath class

It should be a flaky test, works here. CQ, try again!
Comment 5 WebKit Commit Bot 2010-11-03 01:22:19 PDT
Comment on attachment 72661 [details]
remove JSFastMath class

Clearing flags on attachment: 72661

Committed r71220: <http://trac.webkit.org/changeset/71220>
Comment 6 WebKit Commit Bot 2010-11-03 01:22:24 PDT
All reviewed patches have been landed.  Closing bug.