Bug 48835 – Unused class: JSFastMath with JSValue64

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Gabor Loki]

There is an unused class in JSImmediate.h: JSFastMath. It can be safely removed.

[Gabor Loki]

Created attachment 72661 [details]
remove JSFastMath class

[Geoffrey Garen]

Comment on attachment 72661 [details]
remove JSFastMath class

r=me

[WebKit Commit Bot]

Comment on attachment 72661 [details]
remove JSFastMath class

Rejecting patch 72661 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'build-and-test', '--no-clean', '--no-update', '--test', '--non-interactive']" exit_code: 2
Last 500 characters of output:
.....
fast/tokenizer ........................................
fast/transforms .......................
fast/url ....................
fast/workers .............................................
fast/workers/storage ..........................
fast/workers/storage/use-same-database-in-page-and-workers.html -> failed

Exiting early after 1 failures. 16101 tests run.
502.96s total testing time

16100 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
5 test cases (<1%) had stderr output

Full output: http://queues.webkit.org/results/4930021

[Gabor Loki]

Comment on attachment 72661 [details]
remove JSFastMath class

It should be a flaky test, works here. CQ, try again!

[WebKit Commit Bot]

Comment on attachment 72661 [details]
remove JSFastMath class

Clearing flags on attachment: 72661

Committed r71220: <http://trac.webkit.org/changeset/71220>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.