Bug 48834 – Web Inspector: Enable InspectorCSSAgent (not used by frontend for CSS editing yet)

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Alexander Pavlov (apavlov)]

The next step to enabling the source-based CSS editing is to enable InspectorCSSAgent in the "idle" mode: an InspectorCSSAgent instance gets created by InspectorController and is used by InspectorBackendDispatcher, but its functions are not yet used for CSS editing.

[Alexander Pavlov (apavlov)]

Created attachment 72669 [details]
[PATCH] Suggested solution

[Early Warning System Bot]

Attachment 72669 [details] did not build on qt:
Build output: http://queues.webkit.org/results/4941017

[Eric Seidel (no email)]

Attachment 72669 [details] did not build on mac:
Build output: http://queues.webkit.org/results/4994009

[Eric Seidel (no email)]

Attachment 72669 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/4928018

[Alexander Pavlov (apavlov)]

Created attachment 72810 [details]
[PATCH] Compilability fixed, added property value checking with CSSMutableStyleDeclaration::parseDeclaration()

[Alexander Pavlov (apavlov)]

Created attachment 73388 [details]
[WIP] A patch with WebInspector frontend reimplemented to use InspectorCSSAgent

Features:
- Display/modification of CSS properties not parsed by CSSParser (property unrecognized or has invalid structure)
- Multiple same-named properties support (the last property in the style declaration takes precedence)
- Exact calculation of unused CSS size in audits

[Pavel Feldman]

Comment on attachment 73388 [details]
[WIP] A patch with WebInspector frontend reimplemented to use InspectorCSSAgent

I think CSSAgent == CSSStyleModel. I'd just move CSSStyleDeclaration to CSSStyleModel.js. Rationale: we have agents on backend and sdks/ models on front-end. Like InspectorResourceAgent.cpp + ResourceModel,js. I'd also suggest that we first land clear move refactoring and apply incremental changes later. Otherwise it is easy to get lost in the changes within declaration.

[Alexander Pavlov (apavlov)]

(In reply to comment #7)
> (From update of attachment 73388 [details])
> I think CSSAgent == CSSStyleModel. I'd just move CSSStyleDeclaration to CSSStyleModel.js. Rationale: we have agents on backend and sdks/ models on front-end. Like InspectorResourceAgent.cpp + ResourceModel,js. I'd also suggest that we first land clear move refactoring and apply incremental changes later. Otherwise it is easy to get lost in the changes within declaration.

Good, I will file a bug for the move and send out a patch shortly.

[Alexander Pavlov (apavlov)]

Bug 49312 filed for the CSS-related code motion from DOMAgent.js into CSSStyleModel.js

[Alexander Pavlov (apavlov)]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
        M       LayoutTests/ChangeLog
        M       LayoutTests/inspector/styles-source-offsets-expected.txt
        M       LayoutTests/inspector/styles-source-offsets.html
        M       WebCore/ChangeLog
        M       WebCore/inspector/CodeGeneratorInspector.pm
        M       WebCore/inspector/Inspector.idl
        M       WebCore/inspector/InspectorCSSAgent.cpp
        M       WebCore/inspector/InspectorCSSAgent.h
        M       WebCore/inspector/InspectorController.cpp
        M       WebCore/inspector/InspectorController.h
        M       WebCore/inspector/InspectorDOMAgent.cpp
        M       WebCore/inspector/InspectorDOMAgent.h
        M       WebCore/inspector/InspectorStyleSheet.cpp
        M       WebCore/inspector/InspectorStyleSheet.h
Committed r71745