Bug 48808 - Make NPRemoteObjectMap a ref counted object
Summary: Make NPRemoteObjectMap a ref counted object
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-01 17:09 PDT by Anders Carlsson
Modified: 2010-11-01 18:00 PDT (History)
3 users (show)

See Also:

Attachments
Patch (12.15 KB, patch)
2010-11-01 17:11 PDT, Anders Carlsson 		oliver: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2010-11-01 17:09:08 PDT 
Make NPRemoteObjectMap a ref counted object
Comment 1 Anders Carlsson 2010-11-01 17:11:11 PDT 
Created attachment 72604 [details]
Patch
Comment 2 Oliver Hunt 2010-11-01 17:12:12 PDT 
Comment on attachment 72604 [details]
Patch

r=me
Comment 3 Anders Carlsson 2010-11-01 17:13:18 PDT 
Committed r71081: <http://trac.webkit.org/changeset/71081>
Comment 4 WebKit Review Bot 2010-11-01 18:00:38 PDT 
http://trac.webkit.org/changeset/71081 might have broken GTK Linux 64-bit Debug
The following tests are not passing:
http/tests/websocket/tests/alert-in-event-handler.html
http/tests/websocket/tests/bad-handshake-crash.html
http/tests/websocket/tests/bufferedAmount-after-close.html
http/tests/websocket/tests/close-on-navigate-new-location.html
http/tests/websocket/tests/close-on-unload-and-force-gc.html
http/tests/websocket/tests/close-on-unload-reference-in-parent.html
http/tests/websocket/tests/close-on-unload.html
http/tests/websocket/tests/cross-origin.html
http/tests/websocket/tests/error-detect.html
http/tests/websocket/tests/frame-length-longer-than-buffer.html
http/tests/websocket/tests/frame-length-overflow.html
http/tests/websocket/tests/frame-length-skip.html
http/tests/websocket/tests/frame-lengths.html
http/tests/websocket/tests/handshake-challenge-randomness.html
http/tests/websocket/tests/handshake-error.html
http/tests/websocket/tests/handshake-fail-by-cross-origin.html
http/tests/websocket/tests/handshake-fail-by-no-cr.html
http/tests/websocket/tests/handshake-fail-by-sub-protocol-mismatch.html
http/tests/websocket/tests/httponly-cookie.pl
http/tests/websocket/tests/long-invalid-header.html