Bug 48805 - [Soup] Random crashes in http/tests/websocket/tests/workers/worker-handshake-challenge-randomness.html
Summary: [Soup] Random crashes in http/tests/websocket/tests/workers/worker-handshake-...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 48815
Blocks:
  Show dependency treegraph
 
Reported: 2010-11-01 16:39 PDT by Martin Robinson
Modified: 2010-11-02 09:46 PDT (History)
4 users (show)

See Also:


Attachments
Patch for this issue (8.90 KB, patch)
2010-11-01 16:48 PDT, Martin Robinson
no flags Details | Formatted Diff | Diff
Updated patch which fixing HashMap assertion (8.96 KB, patch)
2010-11-01 21:37 PDT, Martin Robinson
xan.lopez: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2010-11-01 16:39:44 PDT
The GTK+ 64-bit Debug bot has seen random crashes. The issue appears to be that active websocket handes are tracked via memory address, which is a not reliable due to reallocations.
Comment 1 Martin Robinson 2010-11-01 16:48:43 PDT
Created attachment 72598 [details]
Patch for this issue
Comment 2 Xan Lopez 2010-11-01 16:56:08 PDT
Comment on attachment 72598 [details]
Patch for this issue

Looks good to me!
Comment 3 Martin Robinson 2010-11-01 17:09:58 PDT
Committed r71080: <http://trac.webkit.org/changeset/71080>
Comment 4 WebKit Review Bot 2010-11-01 18:00:30 PDT
http://trac.webkit.org/changeset/71080 might have broken GTK Linux 64-bit Debug
The following tests are not passing:
http/tests/websocket/tests/alert-in-event-handler.html
http/tests/websocket/tests/bad-handshake-crash.html
http/tests/websocket/tests/bufferedAmount-after-close.html
http/tests/websocket/tests/close-on-navigate-new-location.html
http/tests/websocket/tests/close-on-unload-and-force-gc.html
http/tests/websocket/tests/close-on-unload-reference-in-parent.html
http/tests/websocket/tests/close-on-unload.html
http/tests/websocket/tests/cross-origin.html
http/tests/websocket/tests/error-detect.html
http/tests/websocket/tests/frame-length-longer-than-buffer.html
http/tests/websocket/tests/frame-length-overflow.html
http/tests/websocket/tests/frame-length-skip.html
http/tests/websocket/tests/frame-lengths.html
http/tests/websocket/tests/handshake-challenge-randomness.html
http/tests/websocket/tests/handshake-error.html
http/tests/websocket/tests/handshake-fail-by-cross-origin.html
http/tests/websocket/tests/handshake-fail-by-no-cr.html
http/tests/websocket/tests/handshake-fail-by-sub-protocol-mismatch.html
http/tests/websocket/tests/httponly-cookie.pl
http/tests/websocket/tests/long-invalid-header.html
Comment 5 Martin Robinson 2010-11-01 21:37:49 PDT
Created attachment 72628 [details]
Updated patch which fixing HashMap assertion
Comment 6 Xan Lopez 2010-11-02 08:39:17 PDT
Comment on attachment 72628 [details]
Updated patch which fixing HashMap assertion

r=me
Comment 7 Martin Robinson 2010-11-02 08:52:49 PDT
Committed r71119: <http://trac.webkit.org/changeset/71119>
Comment 8 WebKit Review Bot 2010-11-02 09:46:03 PDT
http://trac.webkit.org/changeset/71119 might have broken GTK Linux 64-bit Debug
The following tests are not passing:
fast/text/international/plane2.html