Bug 48788 – [Chromium]Several fast/transforms tests need linux specific baselines

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Julie Parent]

The following tests just have font metric differences and need chromium-linux specific image baselines:
fast/transforms/transform-on-inline.html
fast/transforms/transform-table-row.html
fast/transforms/transformed-document-element.html

(Current results vs expected results and diffs available here: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showLargeExpectations=true&showExpectations=true&tests=fast%2Ftransforms&useWebKitCanary=true)

[Julie Parent]

Created attachment 72755 [details]
Patch

[Tony Chang]

Comment on attachment 72755 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=72755&action=review

The rotated text on Linux is ugly, but I guess it's no worse than on Windows.

> LayoutTests/platform/chromium/test_expectations.txt:1771
>  // Linux's rotated text output looks terrible.

Please remove this comment as well.

[Julie Parent]

Created attachment 72777 [details]
Patch

[Julie Parent]

Comment on attachment 72777 [details]
Patch

Bah, has other changes in it.

[Julie Parent]

Created attachment 72779 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 72779 [details]
Patch

Rejecting patch 72779 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'apply-attachment', '--force-clean', '--non-interactive', 72779]" exit_code: 2
Last 500 characters of output:
hromium-linux/fast/transforms/transformed-document-element-expected.checksum
patching file LayoutTests/platform/chromium/test_expectations.txt
Hunk #1 succeeded at 936 (offset -3 lines).
Hunk #2 succeeded at 1765 (offset -3 lines).
Hunk #3 FAILED at 3374.
1 out of 3 hunks FAILED -- saving rejects to file LayoutTests/platform/chromium/test_expectations.txt.rej

Failed to run "[u'/Users/abarth/git/webkit-queue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Ojan Vafai', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/5000033

[Julie Parent]

Created attachment 74164 [details]
Patch for landing

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 74164 [details]:

compositing/iframes/overlapped-nested-iframes.html

Please file bugs against the tests.  These tests were authored by [e-mail].  The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 74164 [details]
Patch for landing

Clearing flags on attachment: 74164

Committed r72372: <http://trac.webkit.org/changeset/72372>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.