Bug 48786 - Querying selection start and end should be const
Summary: Querying selection start and end should be const
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Ilya Sherman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-01 14:41 PDT by Ilya Sherman
Modified: 2010-11-05 15:01 PDT (History)
11 users (show)

See Also:

Attachments
Patch (2.14 KB, patch)
2010-11-01 14:46 PDT, Ilya Sherman 		no flags Details | Formatted Diff | Diff
Patch (5.89 KB, patch)
2010-11-05 14:21 PDT, Ilya Sherman 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Sherman 2010-11-01 14:41:40 PDT 
Querying selection start and end should be const
Comment 1 Ilya Sherman 2010-11-01 14:46:29 PDT 
Created attachment 72565 [details]
Patch
Comment 2 WebKit Commit Bot 2010-11-02 12:37:18 PDT 
Comment on attachment 72565 [details]
Patch

Clearing flags on attachment: 72565

Committed r71150: <http://trac.webkit.org/changeset/71150>
Comment 3 WebKit Commit Bot 2010-11-02 12:37:24 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 WebKit Review Bot 2010-11-02 13:32:22 PDT 
http://trac.webkit.org/changeset/71150 might have broken GTK Linux 64-bit Debug
The following tests are not passing:
canvas/philip/tests/toDataURL.jpeg.primarycolours.html
fast/backgrounds/background-repeat-computed-style.html
fast/backgrounds/size/backgroundSize17.html
fast/backgrounds/size/backgroundSize18.html
fast/backgrounds/size/backgroundSize19.html
fast/backgrounds/size/contain-and-cover.html
fast/blockflow/background-horizontal-bt.html
fast/blockflow/background-vertical-lr.html
fast/blockflow/background-vertical-rl.html
fast/canvas/toDataURL-supportedTypes.html
fast/dom/HTMLImageElement/image-load-cross-document.html
fast/dom/HTMLImageElement/image-loading-gc.html
fast/dom/HTMLImageElement/image-natural-width-height.html
fast/dom/HTMLLinkElement/onload-completion-test.html
fast/dom/beforeload/image-before-load-innerHTML.html
fast/dom/beforeload/image-before-load.html
fast/dom/beforeload/image-object-before-load-innerHTML.html
fast/dom/beforeload/image-object-before-load.html
fast/dom/beforeload/remove-image-in-beforeload-listener.html
fast/dom/inner-text-001.html
Comment 5 Ilya Sherman 2010-11-05 14:21:39 PDT 
Created attachment 73117 [details]
Patch
Comment 6 Ilya Sherman 2010-11-05 14:22:57 PDT 
Missed a couple of places with the first patch, including the one that had motivated the patch in the first place -- whoops.
Comment 7 WebKit Commit Bot 2010-11-05 15:01:03 PDT 
Comment on attachment 73117 [details]
Patch

Clearing flags on attachment: 73117

Committed r71452: <http://trac.webkit.org/changeset/71452>
Comment 8 WebKit Commit Bot 2010-11-05 15:01:09 PDT 
All reviewed patches have been landed.  Closing bug.