Bug 48779 - add plugin event logging for linux
Summary: add plugin event logging for linux
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-01 14:10 PDT by Tony Chang
Modified: 2010-11-01 18:00 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.72 KB, patch)
2010-11-01 14:18 PDT, Tony Chang 		tkent: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2010-11-01 14:10:37 PDT 
add plugin event logging for linux
Comment 1 Tony Chang 2010-11-01 14:18:28 PDT 
Created attachment 72558 [details]
Patch
Comment 2 Tony Chang 2010-11-01 14:21:21 PDT 
This fixes LayoutTests/plugins/mouse-events.html for Chromium Linux.
Comment 3 Kent Tamura 2010-11-01 16:08:07 PDT 
Comment on attachment 72558 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=72558&action=review

> WebKitTools/DumpRenderTree/TestNetscapePlugIn/main.cpp:587
> +        // TODO: extract key code

TODO -> FIXME

> WebKitTools/DumpRenderTree/TestNetscapePlugIn/main.cpp:593
> +        // TODO: extract key code

ditto.
Comment 4 Tony Chang 2010-11-01 17:05:27 PDT 
Committed r71078: <http://trac.webkit.org/changeset/71078>
Comment 5 Tony Chang 2010-11-01 17:06:05 PDT 
(In reply to comment #3)
> (From update of attachment 72558 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=72558&action=review
> 
> > WebKitTools/DumpRenderTree/TestNetscapePlugIn/main.cpp:587
> > +        // TODO: extract key code
> 
> TODO -> FIXME
> 
> > WebKitTools/DumpRenderTree/TestNetscapePlugIn/main.cpp:593
> > +        // TODO: extract key code
> 
> ditto.

fixed before landing. thanks!
Comment 6 WebKit Review Bot 2010-11-01 18:00:17 PDT 
http://trac.webkit.org/changeset/71078 might have broken GTK Linux 64-bit Debug
The following tests are not passing:
http/tests/websocket/tests/alert-in-event-handler.html
http/tests/websocket/tests/bad-handshake-crash.html
http/tests/websocket/tests/bufferedAmount-after-close.html
http/tests/websocket/tests/close-on-navigate-new-location.html
http/tests/websocket/tests/close-on-unload-and-force-gc.html
http/tests/websocket/tests/close-on-unload-reference-in-parent.html
http/tests/websocket/tests/close-on-unload.html
http/tests/websocket/tests/cross-origin.html
http/tests/websocket/tests/error-detect.html
http/tests/websocket/tests/frame-length-longer-than-buffer.html
http/tests/websocket/tests/frame-length-overflow.html
http/tests/websocket/tests/frame-length-skip.html
http/tests/websocket/tests/frame-lengths.html
http/tests/websocket/tests/handshake-challenge-randomness.html
http/tests/websocket/tests/handshake-error.html
http/tests/websocket/tests/handshake-fail-by-cross-origin.html
http/tests/websocket/tests/handshake-fail-by-no-cr.html
http/tests/websocket/tests/handshake-fail-by-sub-protocol-mismatch.html
http/tests/websocket/tests/httponly-cookie.pl
http/tests/websocket/tests/long-invalid-header.html