WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
48779
add plugin event logging for linux
https://bugs.webkit.org/show_bug.cgi?id=48779
Summary
add plugin event logging for linux
Tony Chang
Reported
2010-11-01 14:10:37 PDT
add plugin event logging for linux
Attachments
Patch
(3.72 KB, patch)
2010-11-01 14:18 PDT
,
Tony Chang
tkent
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Tony Chang
Comment 1
2010-11-01 14:18:28 PDT
Created
attachment 72558
[details]
Patch
Tony Chang
Comment 2
2010-11-01 14:21:21 PDT
This fixes LayoutTests/plugins/mouse-events.html for Chromium Linux.
Kent Tamura
Comment 3
2010-11-01 16:08:07 PDT
Comment on
attachment 72558
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=72558&action=review
> WebKitTools/DumpRenderTree/TestNetscapePlugIn/main.cpp:587 > + // TODO: extract key code
TODO -> FIXME
> WebKitTools/DumpRenderTree/TestNetscapePlugIn/main.cpp:593 > + // TODO: extract key code
ditto.
Tony Chang
Comment 4
2010-11-01 17:05:27 PDT
Committed
r71078
: <
http://trac.webkit.org/changeset/71078
>
Tony Chang
Comment 5
2010-11-01 17:06:05 PDT
(In reply to
comment #3
)
> (From update of
attachment 72558
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=72558&action=review
> > > WebKitTools/DumpRenderTree/TestNetscapePlugIn/main.cpp:587 > > + // TODO: extract key code > > TODO -> FIXME > > > WebKitTools/DumpRenderTree/TestNetscapePlugIn/main.cpp:593 > > + // TODO: extract key code > > ditto.
fixed before landing. thanks!
WebKit Review Bot
Comment 6
2010-11-01 18:00:17 PDT
http://trac.webkit.org/changeset/71078
might have broken GTK Linux 64-bit Debug The following tests are not passing: http/tests/websocket/tests/alert-in-event-handler.html http/tests/websocket/tests/bad-handshake-crash.html http/tests/websocket/tests/bufferedAmount-after-close.html http/tests/websocket/tests/close-on-navigate-new-location.html http/tests/websocket/tests/close-on-unload-and-force-gc.html http/tests/websocket/tests/close-on-unload-reference-in-parent.html http/tests/websocket/tests/close-on-unload.html http/tests/websocket/tests/cross-origin.html http/tests/websocket/tests/error-detect.html http/tests/websocket/tests/frame-length-longer-than-buffer.html http/tests/websocket/tests/frame-length-overflow.html http/tests/websocket/tests/frame-length-skip.html http/tests/websocket/tests/frame-lengths.html http/tests/websocket/tests/handshake-challenge-randomness.html http/tests/websocket/tests/handshake-error.html http/tests/websocket/tests/handshake-fail-by-cross-origin.html http/tests/websocket/tests/handshake-fail-by-no-cr.html http/tests/websocket/tests/handshake-fail-by-sub-protocol-mismatch.html http/tests/websocket/tests/httponly-cookie.pl http/tests/websocket/tests/long-invalid-header.html
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug