RESOLVED FIXED 48773
Web Inspector: use mimeType from cached resource in case response data contains none. 
https://bugs.webkit.org/show_bug.cgi?id=48773
Summary Web Inspector: use mimeType from cached resource in case response data contai...
Pavel Feldman
Reported 2010-11-01 12:05:44 PDT
For 304 Not Modified resources, response does not contain the mimeType data. Use the one from CachedResource in such cases.
Attachments
[PATCH] Proposed fix. (2.56 KB, patch)
2010-11-01 12:19 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
[PATCH] A cleaner patch. (2.92 KB, patch)
2010-11-01 13:43 PDT, Pavel Feldman 		joepeck: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2010-11-01 12:16:01 PDT
Someone just opened the following a few days ago: <http://webkit.org/b/48525> Web Inspector: Incorrectly reports warning on missing/incorrect content-type for 304s Is this a duplicate?
Pavel Feldman
Comment 2 2010-11-01 12:19:20 PDT
Created attachment 72539 [details] [PATCH] Proposed fix.
Pavel Feldman
Comment 3 2010-11-01 12:21:41 PDT
Hard to tell since the original report references localhost :) But we have good chances of fixing that issue once this patch lands.
Pavel Feldman
Comment 4 2010-11-01 13:43:29 PDT
Created attachment 72550 [details] [PATCH] A cleaner patch.
Joseph Pecoraro
Comment 5 2010-11-01 14:44:21 PDT
Comment on attachment 72550 [details] [PATCH] A cleaner patch. lol, I was just going to suggest that exact change after looking at your first patch. Thanks for making it clearer. You could save a null check by moving this into the "if (cachedResource)" block above, but this is very readable.
Joseph Pecoraro
Comment 6 2010-11-01 14:46:49 PDT
Oh, and it would be awesome if you could check if this fixes bug 48525 after landing.
Pavel Feldman
Comment 7 2010-11-02 03:32:12 PDT
Comment on attachment 72550 [details] [PATCH] A cleaner patch. Committing to http://svn.webkit.org/repository/webkit/trunk M WebCore/ChangeLog M WebCore/inspector/InspectorResourceAgent.cpp M WebCore/inspector/front-end/NetworkPanel.js Committed r71108
Note You need to log in before you can comment on or make changes to this bug.