Bug 48772 - Fixing a bad assert in paintPaginatedChildLayer, hitTestPaginatedChildLayer
Summary: Fixing a bad assert in paintPaginatedChildLayer, hitTestPaginatedChildLayer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Trivial
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-01 11:47 PDT by Abhishek Arya
Modified: 2010-12-26 08:05 PST (History)
5 users (show)

See Also:

Attachments
Patch (4.26 KB, patch)
2010-11-01 12:31 PDT, Abhishek Arya 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Abhishek Arya 2010-11-01 11:47:54 PDT 
Fixing a bad assert in paintPaginatedChildLayer, hitTestPaginatedChildLayer by using the childLayer's renderer instead of this's->renderer
Comment 1 Abhishek Arya 2010-11-01 12:24:41 PDT 
Removing the assert altogether. auto z-index case will hit it.
Comment 2 Abhishek Arya 2010-11-01 12:31:07 PDT 
Created attachment 72541 [details]
Patch
Comment 3 Eric Seidel (no email) 2010-12-10 22:18:22 PST 
@hyatt:  ping?
Comment 4 Eric Seidel (no email) 2010-12-24 17:03:03 PST 
The assert definitely looks bogus.  But maybe Hyatt intended columns to be ignored when boxes were positioned or something?
Comment 5 Abhishek Arya 2010-12-24 18:17:00 PST 
(In reply to comment #4)
> The assert definitely looks bogus.  But maybe Hyatt intended columns to be ignored when boxes were positioned or something?

Dave had said ok on this to remove the assert on irc some time back. I forgot to follow up with him to gave a r+.
Comment 6 Abhishek Arya 2010-12-26 08:05:13 PST 
Comment on attachment 72541 [details]
Patch

Clearing flags on attachment: 72541

Committed r74666: <http://trac.webkit.org/changeset/74666>
Comment 7 Abhishek Arya 2010-12-26 08:05:18 PST 
All reviewed patches have been landed.  Closing bug.