Bug 48770 – [v8] Get rid of automatically generated named property getter for classes with namedItem method

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[anton muhin]

[v8] Get rid of automatically generated named property getter for classes with namedItem method

[anton muhin]

Created attachment 72540 [details]
Patch

[anton muhin]

Modification of layout test expectations can look strange, however compare to http://trac.webkit.org/browser/trunk/LayoutTests/fast/dom/HTMLSelectElement/named-options-expected.txt

Probably layout test itself should be update to better reflect current situation.

[anton muhin]

and this also fixes http://code.google.com/p/chromium/issues/detail?id=61080

[Nate Chapin]

Comment on attachment 72540 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=72540&action=review

> WebCore/bindings/scripts/CodeGeneratorV8.pm:1716
> -    my $hasGetter = $dataNode->extendedAttributes->{"HasNameGetter"} || $hasCustomGetter || $namedPropertyGetter;
> +    my $hasGetter = $dataNode->extendedAttributes->{"HasNameGetter"} || $hasCustomGetter;

If I am reading CodeGeneratorV8.pm correctly, $namedPropertyGetter is now entirely unused.   If that is correct, please remove all other references to it before landing.

[Nate Chapin]

(In reply to comment #4)
> (From update of attachment 72540 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=72540&action=review
> 
> > WebCore/bindings/scripts/CodeGeneratorV8.pm:1716
> > -    my $hasGetter = $dataNode->extendedAttributes->{"HasNameGetter"} || $hasCustomGetter || $namedPropertyGetter;
> > +    my $hasGetter = $dataNode->extendedAttributes->{"HasNameGetter"} || $hasCustomGetter;
> 
> If I am reading CodeGeneratorV8.pm correctly, $namedPropertyGetter is now entirely unused.   If that is correct, please remove all other references to it before landing.

Never mind, I was not reading it correctly.  It looks like we do still need it.

[anton muhin]

Thanks a lot for review, Nate!

(In reply to comment #5)
> (In reply to comment #4)
> > (From update of attachment 72540 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=72540&action=review
> > 
> > > WebCore/bindings/scripts/CodeGeneratorV8.pm:1716
> > > -    my $hasGetter = $dataNode->extendedAttributes->{"HasNameGetter"} || $hasCustomGetter || $namedPropertyGetter;
> > > +    my $hasGetter = $dataNode->extendedAttributes->{"HasNameGetter"} || $hasCustomGetter;
> > 
> > If I am reading CodeGeneratorV8.pm correctly, $namedPropertyGetter is now entirely unused.   If that is correct, please remove all other references to it before landing.
> 
> Never mind, I was not reading it correctly.  It looks like we do still need it.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 72540 [details]:

media/video-poster.html

Please file bugs against the tests.  These tests were authored by [e-mail], [e-mail], and [e-mail].  The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 72540 [details]:

compositing/iframes/overlapped-nested-iframes.html
editing/selection/move-by-line-003.html

Please file bugs against the tests.  These tests were authored by [e-mail] and [e-mail].  The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 72540 [details]:

animations/suspend-resume-animation.html
compositing/video/video-background-color.html

Please file bugs against the tests.  These tests were authored by [e-mail] and [e-mail].  The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 72540 [details]
Patch

Clearing flags on attachment: 72540

Committed r71594: <http://trac.webkit.org/changeset/71594>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.