Bug 48767 – [Qt] QtTestBrowser : set mmp rule pageddata in Symbian

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Dinu Jacob]

QtTestBrowser runs out of memory with most of javascript benchmarks (for example, Dromaeo ). On Symbian it improves memory consumption when   pageddata is enabled.

[George Guo]

agreed with Dinu to fix this.

[George Guo]

Created attachment 72663 [details]
adding paged memory will resolve this issue

[Andreas Kling]

Comment on attachment 72663 [details]
adding paged memory will resolve this issue

View in context: https://bugs.webkit.org/attachment.cgi?id=72663&action=review

> WebKitTools/ChangeLog:5
> +        [Qt] QtTestBrowser : set mmp rule pageddata in Symbian

This ChangeLog entry only covers the "What?" - we also need the "Why?"
Why is this change needed?

[George Guo]

Paing is needed on Symbian devices to support benchmarks test like dromaeo.com and Celtic Kane that need a lot of memory to run.

[George Guo]

Created attachment 72744 [details]
Added why to the patch in addtion to what as reviewer suggested

Made changes to answer why as reviewer suggested.

[Andreas Kling]

Comment on attachment 72744 [details]
Added why to the patch in addtion to what as reviewer suggested

LGTM

[WebKit Commit Bot]

Comment on attachment 72744 [details]
Added why to the patch in addtion to what as reviewer suggested

Rejecting patch 72744 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'apply-attachment', '--force-clean', '--non-interactive', 72744]" exit_code: 2
Last 500 characters of output:
rom bug 48767.
Failed to run "[u'/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Andreas Kling', u'--force']" exit_code: 2
Parsed 2 diffs from patch file(s).
patching file WebKitTools/ChangeLog
patch: **** malformed patch at line 18:  2010-11-01  Jenn Braithwaite  <[e-mail]>

patching file WebKitTools/QtTestBrowser/QtTestBrowser.pro

Failed to run "[u'/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Andreas Kling', u'--force']" exit_code: 2

Full output: http://queues.webkit.org/results/5036015

[George Guo]

Thanks for the patience, i'm fixing the format and preparing the patch

[George Guo]

Created attachment 72814 [details]
Not sure why last patch failed in commit. Remake a patch

[Andreas Kling]

Comment on attachment 72814 [details]
Not sure why last patch failed in commit. Remake a patch

Let's try again. In the future, please tick the "patch" checkbox when uploading patches :)

[Suresh Voruganti]

This patch is required for Qtwebkit 2.1 for increasing Browser stability, so adding dependency to 39121.

[WebKit Commit Bot]

Comment on attachment 72814 [details]
Not sure why last patch failed in commit. Remake a patch

Clearing flags on attachment: 72814

Committed r71302: <http://trac.webkit.org/changeset/71302>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Ademar Reis]

Revision r71302 cherry-picked into qtwebkit-2.1 with commit 68f99d0 <http://gitorious.org/webkit/qtwebkit/commit/68f99d0>