Bug 48764 - [Qt] Need to implement WebKit::pluginWillHandleLoadError for WebKit2
Summary: [Qt] Need to implement WebKit::pluginWillHandleLoadError for WebKit2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Normal
Assignee: Nobody
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2010-11-01 09:44 PDT by Adam Roben (:aroben)
Modified: 2010-11-12 13:11 PST (History)
3 users (show)

See Also:


Attachments
Add the missing error. (4.17 KB, patch)
2010-11-12 07:09 PST, Benjamin Poulain
kling: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2010-11-01 09:44:30 PDT
WebErrorsQt.cpp needs an implementation of pluginWillHandleLoadError. See bug 48561.
Comment 1 Benjamin Poulain 2010-11-12 07:09:42 PST
Created attachment 73737 [details]
Add the missing error.

Untested (I don't have phonon).
Comment 2 Andreas Kling 2010-11-12 09:21:41 PST
Comment on attachment 73737 [details]
Add the missing error.

r=me
Comment 3 WebKit Commit Bot 2010-11-12 09:25:10 PST
Comment on attachment 73737 [details]
Add the missing error.

Rejecting patch 73737 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'apply-attachment', '--force-clean', '--non-interactive', 73737]" exit_code: 2
Last 500 characters of output:
s Kling', u'--force']" exit_code: 1
Parsed 4 diffs from patch file(s).
patching file WebKit/qt/ChangeLog
patching file WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp
patching file WebKit2/ChangeLog
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file WebKit2/ChangeLog.rej
patching file WebKit2/WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp

Failed to run "[u'/Users/abarth/git/webkit-queue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Andreas Kling', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/5774027
Comment 4 Benjamin Poulain 2010-11-12 13:08:32 PST
Committed r71938: <http://trac.webkit.org/changeset/71938>
Comment 5 Benjamin Poulain 2010-11-12 13:11:39 PST
Damn, commit-log-editor failed me over the commit message. :(
Sorry about that.