RESOLVED FIXED 48761
Web Inspector: [Extensions API] expose API to create properties watch sidebar panes 
https://bugs.webkit.org/show_bug.cgi?id=48761
Summary Web Inspector: [Extensions API] expose API to create properties watch sidebar...
Andrey Kosyakov
Reported 2010-11-01 08:45:34 PDT
A common task for extensions would be to display a tree of properties of an object on the inspected page. While it would be possible for extension to re-implement object display and marshaling logic we have in InjectedScript, RemoteObject and PropertiesSection, we would like to provide a simple way for extension to add a sidebar pane similar to our property / expression watch sidebar panes.
Attachments
patch (20.30 KB, patch)
2010-11-01 09:20 PDT, Andrey Kosyakov 		no flags
DetailsFormatted DiffDiff
patch to land (21.53 KB, patch)
2010-11-01 11:32 PDT, Andrey Kosyakov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andrey Kosyakov
Comment 1 2010-11-01 09:20:19 PDT
Created attachment 72515 [details] patch
Pavel Feldman
Comment 2 2010-11-01 10:36:37 PDT
Comment on attachment 72515 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=72515&action=review > WebCore/inspector/front-end/ExtensionAPI.js:271 > + setObject: function(expression, rootTitle) expression -> jsonObject > WebCore/inspector/front-end/ExtensionPanel.js:118 > +WebInspector.LocalJSONObject = function(value) I'd suggest that you move LocalJSONObject into RemoteObject.js and update the factory method there.
Andrey Kosyakov
Comment 3 2010-11-01 11:32:43 PDT
Created attachment 72528 [details] patch to land - Moved LocalJSONObject to RemoteObject.js, added RemoteObject.fromLocalObject() - setObject(expression,...) => setObject(jsonObject,...)
Eric Seidel (no email)
Comment 4 2010-11-10 14:02:48 PST
Comment on attachment 72515 [details] patch Cleared Pavel Feldman's review+ from obsolete attachment 72515 [details] so that this bug does not appear in http://webkit.org/pending-commit.
Andrey Kosyakov
Comment 5 2011-04-08 01:27:06 PDT
Patch laneded at r71107: http://trac.webkit.org/changeset/71107
Note You need to log in before you can comment on or make changes to this bug.